Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910453003: Fixes DBC build for Mac (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Chinmay
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes DBC build for Mac Also, adds an option to the GN build for DBC R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a7295bbb2a03d4bcefc9a570d004a64841ba6cc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M runtime/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/instructions_dbc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
This should also allow Flutter to build with DBC by setting dart_target_arch to dbc, and ...
4 years, 8 months ago (2016-04-20 21:25:02 UTC) #2
Cutch
lgtm
4 years, 8 months ago (2016-04-20 21:26:44 UTC) #3
zra
+ vegorov
4 years, 8 months ago (2016-04-20 21:36:22 UTC) #5
zra
4 years, 8 months ago (2016-04-20 21:38:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a7295bbb2a03d4bcefc9a570d004a64841ba6cc7.

Powered by Google App Engine
This is Rietveld 408576698