Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScope.cpp

Issue 1910403003: Don't allow scripts to run when a node is being adopted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/TreeScope.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScope.cpp b/third_party/WebKit/Source/core/dom/TreeScope.cpp
index 377a865ee6e8271511f83d8517eb7513d65f4c6b..2d1a1b6ee5785db7a5b02c61938eccb91f118cdc 100644
--- a/third_party/WebKit/Source/core/dom/TreeScope.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScope.cpp
@@ -373,8 +373,10 @@ void TreeScope::adoptIfNeeded(Node& node)
DCHECK(this);
DCHECK(!node.isDocumentNode());
TreeScopeAdopter adopter(node, *this);
- if (adopter.needsScopeChange())
+ if (adopter.needsScopeChange()) {
+ ScriptForbiddenScope forbidScript;
esprehn 2016/04/25 20:55:22 This should be at the top of the function. ScriptF
adopter.execute();
+ }
}
Element* TreeScope::retarget(const Element& target) const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698