Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1910393002: Revert of Implement arflags in the GN build. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
brettw, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement arflags in the GN build. (patchset #2 id:20001 of https://codereview.chromium.org/1909163002/ ) Reason for revert: speculatively reverting: issues with linking on the gpu bots again: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/8079 Original issue's description: > Implement arflags in the GN build. > > This flag was recently added in GN. This patch hooks it up to the toolchains > and moves some flags to use it that previously had to be hardcoded on the > tool command itself. > > Remove concurrent_links variable from gcc_toolchain which was unused. > > BUG=598599 > Reland of http://crrev.com/1896163003 with fix. TBR=brucedawson@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598599 Committed: https://crrev.com/2ce39e29422675764e94de94458ce3bb22fe53d3 Cr-Commit-Position: refs/heads/master@{#389000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/posix/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 2 chunks +17 lines, -1 line 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jbudorick
Created Revert of Implement arflags in the GN build.
4 years, 8 months ago (2016-04-22 02:16:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910393002/1
4 years, 8 months ago (2016-04-22 02:17:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 02:17:47 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:43:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ce39e29422675764e94de94458ce3bb22fe53d3
Cr-Commit-Position: refs/heads/master@{#389000}

Powered by Google App Engine
This is Rietveld 408576698