Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1910343002: Fix summary resynthesis in the event of a self-import. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix summary resynthesis in the event of a self-import. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cd119234b2bb355d5786f5346287a586361b5d0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +18 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 4 chunks +15 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-21 23:28:41 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-21 23:30:50 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-21 23:41:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd119234b2bb355d5786f5346287a586361b5d0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698