Allow whitelisted prefs to be displayed in ChromeOS in chrome://local-state.

chrome/browser/ui/webui/local_state/local_state_ui.h

Index: chrome/browser/ui/webui/local_state/local_state_ui.h
diff --git a/chrome/browser/ui/webui/local_state/local_state_ui.h b/chrome/browser/ui/webui/local_state/local_state_ui.h
index e845dae0958c9da4541f153760800e440588fe00..fe262ed05826988562f7bc6c40120362381240d1 100644
--- a/chrome/browser/ui/webui/local_state/local_state_ui.h
+++ b/chrome/browser/ui/webui/local_state/local_state_ui.h
@@ -5,9 +5,18 @@
 #ifndef CHROME_BROWSER_UI_WEBUI_LOCAL_STATE_LOCAL_STATE_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_LOCAL_STATE_LOCAL_STATE_UI_H_
 
+#include <string>
+#include <vector>
+
 #include "base/macros.h"
+#include "base/values.h"

[Alexei Svitkine (slow), 2016/04/25 21:30:13]

Nit: You can forward declare base::DictionaryValue instead.

[hamelphi, 2016/04/26 15:25:28]

Done.

However, can you explain why this is better in this case? In the Google Style
Guide, forward declarations are frowned upon, since it can potentially cause
more trouble down the road (go/fwd_decl_harmful). 

[Alexei Svitkine (slow), 2016/04/26 15:33:34]

Chromium diverges from Google Style here - as the build time improvements are
more relevant for Chromium since most builds are done locally.

See:
https://www.chromium.org/developers/coding-style#TOC-Forward-declarations-vs....

 #include "content/public/browser/web_ui_controller.h"
 
+namespace internal {

[Alexei Svitkine (slow), 2016/04/25 21:30:13]

Nit: Add a short comment about the purpose of this namespace (i.e. for testing).

[hamelphi, 2016/04/26 15:25:28]

Done.

+void FilterPrefs(const std::vector<std::string>& valid_prefixes,

[Alexei Svitkine (slow), 2016/04/25 21:30:13]

Nit: Add a short comment about what this function does.

[hamelphi, 2016/04/26 15:25:28]

Done.

+                 base::DictionaryValue* prefs);
+}
+
 // Controller for chrome://local-state/ page.
 class LocalStateUI : public content::WebUIController {
  public: