Allow whitelisted prefs to be displayed in ChromeOS in chrome://local-state.

chrome/browser/ui/webui/local_state/local_state_ui.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/local_state/local_state_ui.h"
 
-#include <string>
-
 #include "base/json/json_string_value_serializer.h"
 #include "base/macros.h"
+#include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/url_constants.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_controller.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/browser/web_ui_message_handler.h"
 #include "grit/browser_resources.h"
 
 namespace {
 
+// On ChromeOS, the local state file contains some information about other
+// user accounts which we don't want to expose to other users. Use a whitelist
+// to only show variations and UMA related fields which don't contain PII.
+#if defined(OS_CHROMEOS)
+#define ENABLE_FILTERING true
+#else
+#define ENABLE_FILTERING false
+#endif  // defined(OS_CHROMEOS)
+
 // UI Handler for chrome://local-state. Displays the Local State file as JSON.
 class LocalStateUIHandler : public content::WebUIMessageHandler {
  public:
   LocalStateUIHandler();
   ~LocalStateUIHandler() override;
 
   // content::WebUIMessageHandler:
   void RegisterMessages() override;
 
  private:
@@ skipping 10 matching lines @@
 LocalStateUIHandler::~LocalStateUIHandler() {
 }
 
 void LocalStateUIHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "requestJson", base::Bind(&LocalStateUIHandler::HandleRequestJson,
                                 base::Unretained(this)));
 }
 
 void LocalStateUIHandler::HandleRequestJson(const base::ListValue* args) {
-#if !defined(OS_CHROMEOS)
   std::unique_ptr<base::DictionaryValue> local_state_values(
       g_browser_process->local_state()->GetPreferenceValuesOmitDefaults());
-
+  if (ENABLE_FILTERING) {
+    std::vector<std::string> whitelisted_prefixes = {
+        "variations", "user_experience_metrics", "uninstall_metrics"};
+    internal::FilterPrefs(whitelisted_prefixes, local_state_values.get());
+  }
   std::string json;
   JSONStringValueSerializer serializer(&json);
   serializer.set_pretty_print(true);
   bool result = serializer.Serialize(*local_state_values);
   if (!result)
     json = "Error loading Local State file.";
 
   web_ui()->CallJavascriptFunction("localState.setLocalState",
                                    base::StringValue(json));
-#endif  // !defined(OS_CHROMEOS)
+}
+
+// Returns true if |pref_name| starts with one of the |valid_prefixes|.
+bool HasValidPrefix(const std::string& pref_name,
+                    const std::vector<std::string> valid_prefixes) {
+  for (const std::string& prefix : valid_prefixes) {
+    if (pref_name.compare(0, prefix.size(), prefix) == 0)

[Alexei Svitkine (slow), 2016/04/26 17:46:35]

Oops, missed this earlier. Can you change this to StartsWith() from:

https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin...

[hamelphi, 2016/04/26 18:14:54]

Done.

+      return true;
+  }
+  return false;
 }
 
 }  // namespace
 
+namespace internal {
+
+void FilterPrefs(const std::vector<std::string>& valid_prefixes,
+                 base::DictionaryValue* prefs) {
+  std::vector<std::string> prefs_to_remove;
+  for (base::DictionaryValue::Iterator it(*prefs); !it.IsAtEnd();
+       it.Advance()) {
+    if (!HasValidPrefix(it.key(), valid_prefixes))
+      prefs_to_remove.push_back(it.key());
+  }
+  for (const std::string& pref_to_remove : prefs_to_remove) {
+    std::unique_ptr<base::Value> removed_value;
+    bool successfully_removed = prefs->Remove(pref_to_remove, &removed_value);
+    DCHECK(successfully_removed);
+  }
+}
+
+}  // namespace internal
+
 LocalStateUI::LocalStateUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   // Set up the chrome://local-state source.
   content::WebUIDataSource* html_source =
       content::WebUIDataSource::Create(chrome::kChromeUILocalStateHost);
   html_source->SetDefaultResource(IDR_LOCAL_STATE_HTML);
   html_source->AddResourcePath("local_state.js", IDR_LOCAL_STATE_JS);
   content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), html_source);
 
   // AddMessageHandler takes ownership of LocalStateUIHandler.
   web_ui->AddMessageHandler(new LocalStateUIHandler);
 }
 
 LocalStateUI::~LocalStateUI() {
 }