EME: Check for invalid Key System names on addition

media/base/key_systems.cc

Index: media/base/key_systems.cc
diff --git a/media/base/key_systems.cc b/media/base/key_systems.cc
index 675df7b3960760978597bb32a6a92d89e245066f..bb4f8d2eb077a149b2c92dd0677b7630cbd2dad4 100644
--- a/media/base/key_systems.cc
+++ b/media/base/key_systems.cc
@@ -377,6 +377,13 @@ void KeySystemsImpl::AddSupportedKeySystems(
     DCHECK(properties->GetDistinctiveIdentifierSupport() !=
            EmeFeatureSupport::INVALID);
 
+    if (!IsPotentiallySupportedKeySystem(properties->GetKeySystemName())) {
+      // If you encounter this path, see the comments for the above function.

[xhwang, 2016/05/20 17:10:14]

nit: which above function?

[ddorwin, 2016/05/20 17:19:27]

The one in the if statement. Is there a better way to reference it without using
its name?

[xhwang, 2016/05/20 17:22:31]

I see. When I see "above function" I was looking at UpdateSupportedKeySystems()
:) I guess this is okay.

[ddorwin, 2016/05/20 22:47:20]

I improved it a tiny bit.

+      DLOG(ERROR) << "Unsupported name '" << properties->GetKeySystemName()
+                  << "'. See code comments.";
+      continue;
+    }
+
     // Supporting persistent state is a prerequsite for supporting persistent
     // sessions.
     if (properties->GetPersistentStateSupport() ==
@@ -547,15 +554,6 @@ bool KeySystemsImpl::IsSupportedKeySystem(const std::string& key_system) const {
   if (!key_system_properties_map_.count(key_system))
     return false;
 
-  // TODO(ddorwin): Move this to where we add key systems when prefixed EME is
-  // removed (crbug.com/249976).
-  if (!IsPotentiallySupportedKeySystem(key_system)) {
-    // If you encounter this path, see the comments for the above function.
-    DLOG(ERROR) << "Unrecognized key system " << key_system
-                << ". See code comments.";
-    return false;
-  }
-
   return true;
 }