EME: Check for invalid Key System names on addition

EME: Check for invalid Key System names on addition

Prefixed implementations supported invalid names so we only checked in the
unprefixed use path. Now, these should never be provided, so we can check
on addition like other Key System properties.

BUG=249976
Committed: https://crrev.com/82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc
Cr-Commit-Position: refs/heads/master@{#395239}

[ddorwin, 2016-05-20 17:02:18]

ddorwin@chromium.org changed reviewers:
+ boliu@chromium.org, xhwang@chromium.org

[ddorwin, 2016-05-20 17:02:18]

xhwang, PTAL.

boliu: FYI on a change that affects when we check platform CDMs.

[xhwang, 2016-05-20 17:10:14]

LGTM with question/nit

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems.cc
File media/base/key_systems.cc (right):

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:169: // for real key system names. Use is discouraged.
OOC, where do we use this?

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:381: // If you encounter this path, see the comments
for the above function.
nit: which above function?

[ddorwin, 2016-05-20 17:19:27]

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems.cc
File media/base/key_systems.cc (right):

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:169: // for real key system names. Use is discouraged.
On 2016/05/20 17:10:14, xhwang wrote:
> OOC, where do we use this?

Platform key systems on Android TV.

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:381: // If you encounter this path, see the comments
for the above function.
On 2016/05/20 17:10:14, xhwang wrote:
> nit: which above function?

The one in the if statement. Is there a better way to reference it without using
its name?

[xhwang, 2016-05-20 17:22:31]

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems.cc
File media/base/key_systems.cc (right):

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:169: // for real key system names. Use is discouraged.
On 2016/05/20 17:19:27, ddorwin wrote:
> On 2016/05/20 17:10:14, xhwang wrote:
> > OOC, where do we use this?
> 
> Platform key systems on Android TV.

Acknowledged.

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:381: // If you encounter this path, see the comments
for the above function.
On 2016/05/20 17:19:27, ddorwin wrote:
> On 2016/05/20 17:10:14, xhwang wrote:
> > nit: which above function?
> 
> The one in the if statement. Is there a better way to reference it without
using
> its name?

I see. When I see "above function" I was looking at UpdateSupportedKeySystems()
:) I guess this is okay.

[ddorwin, 2016-05-20 22:47:20]

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems.cc
File media/base/key_systems.cc (right):

https://codereview.chromium.org/1910283003/diff/120001/media/base/key_systems...
media/base/key_systems.cc:381: // If you encounter this path, see the comments
for the above function.
On 2016/05/20 17:22:31, xhwang wrote:
> On 2016/05/20 17:19:27, ddorwin wrote:
> > On 2016/05/20 17:10:14, xhwang wrote:
> > > nit: which above function?
> > 
> > The one in the if statement. Is there a better way to reference it without
> using
> > its name?
> 
> I see. When I see "above function" I was looking at
UpdateSupportedKeySystems()
> :) I guess this is okay.

I improved it a tiny bit.

[ddorwin, 2016-05-20 22:47:25]

The CQ bit was checked by ddorwin@chromium.org

[ddorwin, 2016-05-20 22:47:26]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1910283003/#ps140001
(title: "Slightly improve comment")

[commit-bot: I haz the power, 2016-05-20 22:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910283003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910283003/140001

[commit-bot: I haz the power, 2016-05-21 03:11:25]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-21 03:12:48]

Description was changed from

==========
EME: Check for invalid Key System names on addition

Prefixed implementations supported invalid names so we only checked in the
unprefixed use path. Now, these should never be provided, so we can check
on addition like other Key System properties.

BUG=249976
==========

to

==========
EME: Check for invalid Key System names on addition

Prefixed implementations supported invalid names so we only checked in the
unprefixed use path. Now, these should never be provided, so we can check
on addition like other Key System properties.

BUG=249976

Committed: https://crrev.com/82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc
Cr-Commit-Position: refs/heads/master@{#395239}
==========

[commit-bot: I haz the power, 2016-05-21 03:12:54]

Patchset 8 (id:??) landed as
https://crrev.com/82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc
Cr-Commit-Position: refs/heads/master@{#395239}