Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1910283002: build/install-build-deps.sh: support Ubuntu 16.04 (xenial). (Closed)

Created:
4 years, 8 months ago by krasin1
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= Committed: https://crrev.com/eef3d4b229af09da83a2dfee8fe691c2874c0d36 Cr-Commit-Position: refs/heads/master@{#388983}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M build/install-build-deps.sh View 4 chunks +29 lines, -6 lines 2 comments Download

Messages

Total messages: 17 (8 generated)
krasin
Hi Elliott! Please, review this CL that fixes issues with install-build-deps.sh related to Ubuntu 16.04. ...
4 years, 8 months ago (2016-04-21 23:17:19 UTC) #2
krasin
The audio manager related issues are not specific to Ubuntu 16.04: https://crbug.com/605432
4 years, 8 months ago (2016-04-21 23:32:47 UTC) #3
Ryan Tseng
+dpranke (a src/build owner)
4 years, 8 months ago (2016-04-21 23:59:05 UTC) #7
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-22 00:03:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910283002/1
4 years, 8 months ago (2016-04-22 00:04:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 00:52:28 UTC) #12
friedman1
https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh#newcode164 build/install-build-deps.sh:164: wily) FYI this could be merged here with: wily|xenial) ...
4 years, 8 months ago (2016-04-22 01:27:25 UTC) #14
krasin
https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh#newcode164 build/install-build-deps.sh:164: wily) On 2016/04/22 01:27:25, friedman1 wrote: > FYI this ...
4 years, 8 months ago (2016-04-22 01:31:49 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:42:45 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eef3d4b229af09da83a2dfee8fe691c2874c0d36
Cr-Commit-Position: refs/heads/master@{#388983}

Powered by Google App Engine
This is Rietveld 408576698