|
|
Descriptionbuild/install-build-deps.sh: support Ubuntu 16.04 (xenial).
BUG=
Committed: https://crrev.com/eef3d4b229af09da83a2dfee8fe691c2874c0d36
Cr-Commit-Position: refs/heads/master@{#388983}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (8 generated)
krasin@google.com changed reviewers: + friedman@chromium.org, krasin@google.com
Hi Elliott! Please, review this CL that fixes issues with install-build-deps.sh related to Ubuntu 16.04. I was able to build chrome and successfully run the following test suites: unit_tests, browser_tests, cc_unittests, components_browsertests, extensions_browsertests, content_browsertests. I observed a sporadic issue while running tests "Multiple instances of AudioManager detected", but it has likely nothing to do with the build deps, and shall be addressed separately. krasin
The audio manager related issues are not specific to Ubuntu 16.04: https://crbug.com/605432
Description was changed from ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= ========== to ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= ==========
hinoka@google.com changed reviewers: + dpranke@chromium.org
hinoka@google.com changed reviewers: + hinoka@google.com
+dpranke (a src/build owner)
lgtm
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910283002/1
Message was sent while issue was closed.
Description was changed from ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= ========== to ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
friedman@google.com changed reviewers: + friedman@google.com
Message was sent while issue was closed.
https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh... build/install-build-deps.sh:164: wily) FYI this could be merged here with: wily|xenial) but this is fine.
Message was sent while issue was closed.
https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/1910283002/diff/1/build/install-build-deps.sh... build/install-build-deps.sh:164: wily) On 2016/04/22 01:27:25, friedman1 wrote: > FYI this could be merged here with: > wily|xenial) > but this is fine. yeah, I've considered that, but given how awkward the bash syntax is, I decided to keep it simple. I agree that the merge will be necessary, if Ubuntu 16.10 has the same issue (which is very likely)
Message was sent while issue was closed.
Description was changed from ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= ========== to ========== build/install-build-deps.sh: support Ubuntu 16.04 (xenial). BUG= Committed: https://crrev.com/eef3d4b229af09da83a2dfee8fe691c2874c0d36 Cr-Commit-Position: refs/heads/master@{#388983} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eef3d4b229af09da83a2dfee8fe691c2874c0d36 Cr-Commit-Position: refs/heads/master@{#388983} |