Chromium Code Reviews
DescriptionRevert of Add :media_feature dependency for GN media/base and media/base/test_support targets (patchset #1 id:1 of https://codereview.chromium.org/1907003002/ )
Reason for revert:
Win build compiler error: https://build.chromium.org/p/chromium/builders/Win/builds/42636
Original issue's description:
> Add :media_feature dependency for GN media/base and media/base/test_support targets
>
> The media/media_features.h header is generated by //media:media_features
> GN target. I've included that header into video_decoder_config.h. But
> turns out the video_decoder_config.h header is used in targets other
> than //media (which already has a dependency on //media:media_features).
> We need to add //media:media_features dependency for all targets that
> use video_decoder_config.h header.
>
> BUG=605700
TBR=xhwang@chromium.org,ddorwin@chromium.org,wolenetz@chromium.org,servolk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605700
Committed: https://crrev.com/db9e10eea47ab530e34a9b73fa9d230ddb8d0c05
Cr-Commit-Position: refs/heads/master@{#388921}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||