Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 1910273002: Revert of Add :media_feature dependency for GN media/base and media/base/test_support targets (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add :media_feature dependency for GN media/base and media/base/test_support targets (patchset #1 id:1 of https://codereview.chromium.org/1907003002/ ) Reason for revert: Win build compiler error: https://build.chromium.org/p/chromium/builders/Win/builds/42636 Original issue's description: > Add :media_feature dependency for GN media/base and media/base/test_support targets > > The media/media_features.h header is generated by //media:media_features > GN target. I've included that header into video_decoder_config.h. But > turns out the video_decoder_config.h header is used in targets other > than //media (which already has a dependency on //media:media_features). > We need to add //media:media_features dependency for all targets that > use video_decoder_config.h header. > > BUG=605700 TBR=xhwang@chromium.org,ddorwin@chromium.org,wolenetz@chromium.org,servolk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605700 Committed: https://crrev.com/db9e10eea47ab530e34a9b73fa9d230ddb8d0c05 Cr-Commit-Position: refs/heads/master@{#388921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
apacible
Created Revert of Add :media_feature dependency for GN media/base and media/base/test_support targets
4 years, 8 months ago (2016-04-21 22:25:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910273002/1
4 years, 8 months ago (2016-04-21 22:26:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 22:26:42 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db9e10eea47ab530e34a9b73fa9d230ddb8d0c05
Cr-Commit-Position: refs/heads/master@{#388921}

Powered by Google App Engine
This is Rietveld 408576698