Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910263004: Code completion progress part one of fix to https://github.com/dart-lang/sdk/issues/24254, addition… (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code completion progress part one of fix to https://github.com/dart-lang/sdk/issues/24254, addition of optype.includeVarNameSuggestions BUG=https://github.com/dart-lang/sdk/issues/24254 R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/58bf3075a803d7dcc2c9180ab35f348e053e16de

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment from danr, rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 4 chunks +21 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 7 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
4 years, 8 months ago (2016-04-21 22:01:46 UTC) #2
danrubel
LGTM https://codereview.chromium.org/1910263004/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart File pkg/analysis_server/lib/src/services/completion/dart/optype.dart (right): https://codereview.chromium.org/1910263004/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart#newcode388 pkg/analysis_server/lib/src/services/completion/dart/optype.dart:388: if ((token.lexeme.length == 0 || token.lexeme == ';') ...
4 years, 8 months ago (2016-04-21 23:29:52 UTC) #3
jwren
4 years, 8 months ago (2016-04-22 18:00:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
58bf3075a803d7dcc2c9180ab35f348e053e16de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698