src/x64/builtins-x64.cc - Issue 1910253005: [api] Expose FunctionCallbackInfo::NewTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 1910253005: [api] Expose FunctionCallbackInfo::NewTarget (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: IsConstructCall refactor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 8d2a0fd6e1046a6b026a33aa71ba843089233b91..c66cbdabbe307a6ecb94af5b8c1837c8c8cf22a8 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -187,8 +187,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,

// Call the function.

if (is_api_function) {

Benedikt Meurer 2016/04/26 04:21:34 You shouldn't need this if anymore. The InvokeFunc

adamk 2016/04/26 18:17:14 Done.

Benedikt Meurer 2016/04/26 18:28:40 Acknowledged.

__ movp(rsi, FieldOperand(rdi, JSFunction::kContextOffset));

- Handle<Code> code =

- masm->isolate()->builtins()->HandleApiCallConstruct();

+ Handle<Code> code = masm->isolate()->builtins()->HandleApiCall();

__ Call(code, RelocInfo::CODE_TARGET);

} else {

ParameterCount actual(rax);