src/x64/code-stubs-x64.cc - Issue 1910253005: [api] Expose FunctionCallbackInfo::NewTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 1910253005: [api] Expose FunctionCallbackInfo::NewTarget (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index f489a90c37d9e46a541f62083558e4d6b7efe478..2f980efe08418b7adcaf7029048579c035c8c997 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -5404,10 +5404,14 @@ void CallApiCallbackStub::Generate(MacroAssembler* masm) {

STATIC_ASSERT(FCA::kReturnValueDefaultValueIndex == 2);

STATIC_ASSERT(FCA::kIsolateIndex == 1);

STATIC_ASSERT(FCA::kHolderIndex == 0);

- STATIC_ASSERT(FCA::kArgsLength == 7);

+ STATIC_ASSERT(FCA::kNewTargetIndex == 7);

+ STATIC_ASSERT(FCA::kArgsLength == 8);

__ PopReturnAddressTo(return_address);

+ // new target

+ __ PushRoot(Heap::kUndefinedValueRootIndex);

// context save

__ Push(context);