Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1910233005: Ensure display item ids are unique for image areas (Closed)

Created:
4 years, 8 months ago by pdr.
Modified:
4 years, 8 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure display item ids are unique for image areas When painting the focus ring for an image map's area, we would use the same display item id (layout object + phase) for both the image's outline and the focus ring. This patch creates a separate display item type for image area focus rings. BUG=606113 Committed: https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8 Cr-Commit-Position: refs/heads/master@{#389392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/images/imagemap-duplicate-outlines-crash-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pdr.
4 years, 8 months ago (2016-04-23 04:04:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910233005/1
4 years, 8 months ago (2016-04-23 04:05:22 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/210371)
4 years, 8 months ago (2016-04-23 10:06:08 UTC) #6
Xianzhu
lgtm Thanks!
4 years, 8 months ago (2016-04-23 21:24:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910233005/1
4 years, 8 months ago (2016-04-23 21:24:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 22:55:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 22:57:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2ef23f23e20d28e9e611961c27fbaa0d49333a8
Cr-Commit-Position: refs/heads/master@{#389392}

Powered by Google App Engine
This is Rietveld 408576698