fixes #516, nested cascade code generation

fixes #516, nested cascade code generation
our let* was not hygenic, due to incorrect use of named substitution

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/c233d2f4ef51d2bbfd5fb26409dd73311c1bcaaa

[Jennifer Messerly, 2016-04-21 21:27:02]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2016-04-21 21:27:07]

Patchset #1 (id:20001) has been deleted

[Jennifer Messerly, 2016-04-21 21:28:17]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-04-21 21:50:48]

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:1917: return element.variable;
This doesn't match the return type of this function, right?

[Jennifer Messerly, 2016-04-21 21:53:25]

(and I did run full presubmit)

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:1917: return element.variable;
On 2016/04/21 21:50:48, vsm wrote:
> This doesn't match the return type of this function, right?

JS.Expression visitSimpleIdentifier ... and we're returning a JS.Expression, I
don't see the problem?
if it helps I can rename it to "jsVariable"?

[vsm, 2016-04-21 22:06:22]

lgtm

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1910233002/diff/40001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:1917: return element.variable;
On 2016/04/21 21:53:25, John Messerly wrote:
> On 2016/04/21 21:50:48, vsm wrote:
> > This doesn't match the return type of this function, right?
> 
> JS.Expression visitSimpleIdentifier ... and we're returning a JS.Expression, I
> don't see the problem?
> if it helps I can rename it to "jsVariable"?

Oh, I missed that TemporaryVariableElement is our class, not the analyzer's.  I
was confused how it had a JS.Expression on it (even you edited it below :-)).

[Jennifer Messerly, 2016-04-21 22:18:29]

Thanks! Yeah it's confusing. I added a comment and changed the name to hopefully
make it a bit more clear.

[Jennifer Messerly, 2016-04-21 22:19:21]

Description was changed from

==========
fixes #516, nested cascade code generation
our let* was not hygenic, due to incorrect use of named substitution
==========

to

==========
fixes #516, nested cascade code generation
our let* was not hygenic, due to incorrect use of named substitution

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/c233d2f4ef51d2bbfd5fb26409dd...
==========

[Jennifer Messerly, 2016-04-21 22:19:24]

Committed patchset #3 (id:80001) manually as
c233d2f4ef51d2bbfd5fb26409dd73311c1bcaaa (presubmit successful).