Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11477)

Unified Diff: cc/raster/tile_task_worker_pool_perftest.cc

Issue 1910213005: cc: Refactor TileTaskWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@task_states
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/tile_task_worker_pool_perftest.cc
diff --git a/cc/raster/tile_task_worker_pool_perftest.cc b/cc/raster/tile_task_worker_pool_perftest.cc
index 46251dc9a35cbdb932f78514bc776fa0b7a5ba6c..135477683bcf978497dba2c3a575bf3424b6af99 100644
--- a/cc/raster/tile_task_worker_pool_perftest.cc
+++ b/cc/raster/tile_task_worker_pool_perftest.cc
@@ -28,6 +28,7 @@
#include "cc/test/test_gpu_memory_buffer_manager.h"
#include "cc/test/test_shared_bitmap_manager.h"
#include "cc/test/test_web_graphics_context_3d.h"
+#include "cc/tiles/tile_task_manager.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/perf/perf_test.h"
#include "third_party/khronos/GLES2/gl2.h"
@@ -255,41 +256,41 @@ class TileTaskWorkerPoolPerfTest
public:
// Overridden from testing::Test:
void SetUp() override {
+ std::unique_ptr<TileTaskWorkerPool> tile_task_worker_pool;
switch (GetParam()) {
case TILE_TASK_WORKER_POOL_TYPE_ZERO_COPY:
Create3dOutputSurfaceAndResourceProvider();
- tile_task_worker_pool_ = ZeroCopyTileTaskWorkerPool::Create(
- task_runner_.get(), task_graph_runner_.get(),
+ tile_task_worker_pool = ZeroCopyTileTaskWorkerPool::Create(
resource_provider_.get(), PlatformColor::BestTextureFormat());
break;
case TILE_TASK_WORKER_POOL_TYPE_ONE_COPY:
Create3dOutputSurfaceAndResourceProvider();
- tile_task_worker_pool_ = OneCopyTileTaskWorkerPool::Create(
- task_runner_.get(), task_graph_runner_.get(),
- context_provider_.get(), resource_provider_.get(),
- std::numeric_limits<int>::max(), false,
+ tile_task_worker_pool = OneCopyTileTaskWorkerPool::Create(
+ task_runner_.get(), context_provider_.get(),
+ resource_provider_.get(), std::numeric_limits<int>::max(), false,
std::numeric_limits<int>::max(),
PlatformColor::BestTextureFormat());
break;
case TILE_TASK_WORKER_POOL_TYPE_GPU:
Create3dOutputSurfaceAndResourceProvider();
- tile_task_worker_pool_ = GpuTileTaskWorkerPool::Create(
- task_runner_.get(), task_graph_runner_.get(),
+ tile_task_worker_pool = GpuTileTaskWorkerPool::Create(
context_provider_.get(), resource_provider_.get(), false, 0);
break;
case TILE_TASK_WORKER_POOL_TYPE_BITMAP:
CreateSoftwareOutputSurfaceAndResourceProvider();
- tile_task_worker_pool_ = BitmapTileTaskWorkerPool::Create(
- task_runner_.get(), task_graph_runner_.get(),
- resource_provider_.get());
+ tile_task_worker_pool =
+ BitmapTileTaskWorkerPool::Create(resource_provider_.get());
break;
}
- DCHECK(tile_task_worker_pool_);
+ DCHECK(tile_task_worker_pool);
+
+ tile_task_manager_ = TileTaskManager::Create(
+ std::move(tile_task_worker_pool), task_graph_runner_.get());
}
void TearDown() override {
- tile_task_worker_pool_->Shutdown();
- tile_task_worker_pool_->CheckForCompletedTasks();
+ tile_task_manager_->Shutdown();
+ tile_task_manager_->CheckForCompletedTasks();
}
void RunMessageLoopUntilAllTasksHaveCompleted() {
@@ -310,13 +311,13 @@ class TileTaskWorkerPoolPerfTest
do {
graph.Reset();
BuildTileTaskGraph(&graph, raster_tasks);
- tile_task_worker_pool_->ScheduleTasks(&graph);
- tile_task_worker_pool_->CheckForCompletedTasks();
+ tile_task_manager_->ScheduleTasks(&graph);
+ tile_task_manager_->CheckForCompletedTasks();
timer_.NextLap();
} while (!timer_.HasTimeLimitExpired());
TaskGraph empty;
- tile_task_worker_pool_->ScheduleTasks(&empty);
+ tile_task_manager_->ScheduleTasks(&empty);
RunMessageLoopUntilAllTasksHaveCompleted();
perf_test::PrintResult("schedule_tasks", TestModifierString(), test_name,
@@ -341,14 +342,14 @@ class TileTaskWorkerPoolPerfTest
do {
graph.Reset();
BuildTileTaskGraph(&graph, raster_tasks[count % kNumVersions]);
- tile_task_worker_pool_->ScheduleTasks(&graph);
- tile_task_worker_pool_->CheckForCompletedTasks();
+ tile_task_manager_->ScheduleTasks(&graph);
+ tile_task_manager_->CheckForCompletedTasks();
++count;
timer_.NextLap();
} while (!timer_.HasTimeLimitExpired());
TaskGraph empty;
- tile_task_worker_pool_->ScheduleTasks(&empty);
+ tile_task_manager_->ScheduleTasks(&empty);
RunMessageLoopUntilAllTasksHaveCompleted();
perf_test::PrintResult("schedule_alternate_tasks", TestModifierString(),
@@ -368,13 +369,13 @@ class TileTaskWorkerPoolPerfTest
do {
graph.Reset();
BuildTileTaskGraph(&graph, raster_tasks);
- tile_task_worker_pool_->ScheduleTasks(&graph);
+ tile_task_manager_->ScheduleTasks(&graph);
RunMessageLoopUntilAllTasksHaveCompleted();
timer_.NextLap();
} while (!timer_.HasTimeLimitExpired());
TaskGraph empty;
- tile_task_worker_pool_->ScheduleTasks(&empty);
+ tile_task_manager_->ScheduleTasks(&empty);
RunMessageLoopUntilAllTasksHaveCompleted();
perf_test::PrintResult("schedule_and_execute_tasks", TestModifierString(),
@@ -412,7 +413,7 @@ class TileTaskWorkerPoolPerfTest
return std::string();
}
- std::unique_ptr<TileTaskWorkerPool> tile_task_worker_pool_;
+ std::unique_ptr<TileTaskManager> tile_task_manager_;
TestGpuMemoryBufferManager gpu_memory_buffer_manager_;
TestSharedBitmapManager shared_bitmap_manager_;
};

Powered by Google App Engine
This is Rietveld 408576698