Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: cc/raster/tile_task_worker_pool.h

Issue 1910213005: cc: Refactor TileTaskWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@task_states
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/tile_task_worker_pool.h
diff --git a/cc/raster/tile_task_worker_pool.h b/cc/raster/tile_task_worker_pool.h
index 9542d0264ae86b786811c1cd57c2aa6690238079..5c66b9247725af4be4129f7f4309aeb19744b7ff 100644
--- a/cc/raster/tile_task_worker_pool.h
+++ b/cc/raster/tile_task_worker_pool.h
@@ -20,22 +20,12 @@ class SequencedTaskRunner;
}
namespace cc {
-class RenderingStatsInstrumentation;
-// This class provides the wrapper over TaskGraphRunner for scheduling and
-// collecting tasks. The client can call CheckForCompletedTasks() at any time to
-// process all completed tasks at the moment that have finished running or
-// cancelled.
class CC_EXPORT TileTaskWorkerPool {
public:
TileTaskWorkerPool();
virtual ~TileTaskWorkerPool();
- // Utility function that can be used to call ::ScheduleOnOriginThread() for
- // each task in |graph|.
- static void ScheduleTasksOnOriginThread(RasterBufferProvider* provider,
- TaskGraph* graph);
-
// Utility function that will create a temporary bitmap and copy pixels to
// |memory| when necessary. The |canvas_bitmap_rect| is the rect of the bitmap
// being played back in the pixel space of the source, ie a rect in the source
@@ -53,20 +43,8 @@ class CC_EXPORT TileTaskWorkerPool {
float scale,
const RasterSource::PlaybackSettings& playback_settings);
- // Tells the worker pool to shutdown after canceling all previously scheduled
- // tasks. Reply callbacks are still guaranteed to run when
- // CheckForCompletedTasks() is called.
- virtual void Shutdown() = 0;
-
- // Schedule running of tile tasks in |graph| and all dependencies.
- // Previously scheduled tasks that are not in |graph| will be canceled unless
- // already running. Once scheduled, reply callbacks are guaranteed to run for
- // all tasks even if they later get canceled by another call to
- // ScheduleTasks().
- virtual void ScheduleTasks(TaskGraph* graph) = 0;
-
- // Check for completed tasks and dispatch reply callbacks.
- virtual void CheckForCompletedTasks() = 0;
+ // Barrier to sync any new resources to the worker context.
+ virtual void BarrierToSyncResources() = 0;
// Returns the format to use for the tiles.
virtual ResourceFormat GetResourceFormat(bool must_support_alpha) const = 0;

Powered by Google App Engine
This is Rietveld 408576698