Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: cc/raster/bitmap_tile_task_worker_pool.h

Issue 1910213005: cc: Refactor TileTaskWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@task_states
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/bitmap_tile_task_worker_pool.h
diff --git a/cc/raster/bitmap_tile_task_worker_pool.h b/cc/raster/bitmap_tile_task_worker_pool.h
index 5d7e40954e9483febe92a4cc3417f917b70d2c7b..fefc7fa9245bda9e3dfe3954eecf3adbc9a16be6 100644
--- a/cc/raster/bitmap_tile_task_worker_pool.h
+++ b/cc/raster/bitmap_tile_task_worker_pool.h
@@ -26,14 +26,10 @@ class CC_EXPORT BitmapTileTaskWorkerPool : public TileTaskWorkerPool,
~BitmapTileTaskWorkerPool() override;
static std::unique_ptr<TileTaskWorkerPool> Create(
- base::SequencedTaskRunner* task_runner,
- TaskGraphRunner* task_graph_runner,
ResourceProvider* resource_provider);
// Overridden from TileTaskWorkerPool:
- void Shutdown() override;
- void ScheduleTasks(TaskGraph* graph) override;
- void CheckForCompletedTasks() override;
+ void BarrierToSyncResources() override;
ResourceFormat GetResourceFormat(bool must_support_alpha) const override;
bool GetResourceRequiresSwizzle(bool must_support_alpha) const override;
RasterBufferProvider* AsRasterBufferProvider() override;
@@ -46,21 +42,14 @@ class CC_EXPORT BitmapTileTaskWorkerPool : public TileTaskWorkerPool,
void ReleaseBufferForRaster(std::unique_ptr<RasterBuffer> buffer) override;
protected:
- BitmapTileTaskWorkerPool(base::SequencedTaskRunner* task_runner,
- TaskGraphRunner* task_graph_runner,
- ResourceProvider* resource_provider);
+ explicit BitmapTileTaskWorkerPool(ResourceProvider* resource_provider);
private:
std::unique_ptr<base::trace_event::ConvertableToTraceFormat> StateAsValue()
const;
- scoped_refptr<base::SequencedTaskRunner> task_runner_;
- TaskGraphRunner* task_graph_runner_;
- const NamespaceToken namespace_token_;
ResourceProvider* resource_provider_;
- Task::Vector completed_tasks_;
-
DISALLOW_COPY_AND_ASSIGN(BitmapTileTaskWorkerPool);
};

Powered by Google App Engine
This is Rietveld 408576698