Reland of DocumentLoader should commit the load before creating a DocumentWriter

Reland of DocumentLoader should commit the load before creating a DocumentWriter

The current order of events in DocumentLoader causes an HTML parser to be created via DocumentWriter::create before the load commits. This causes the HTML parser to read a stale value for scriptEnabled setting in HTMLParserOptions if the setting changes between page loads. This in turn breaks the rendering of noscript tags.

This CL moves receivedFirstData call before DocumentWriter::create and FrameLoader::didBeginDocument so that the load is committed before the HTML parser is created and the correct scriptEnabled value is used by the parser. It also moves creation of Content Security Policy and setting saved form data to a new callback didInstallNewDocument.

NOTE: This also changes the order of callbacks in WebFrameClient.
The OLD order when loading a document was:
1. didStartProvisionalLoad
2. didCreateNewDocument
3. didCommitProvisionalLoad
4. didCreateDocumentElement

The NEW order is:
1. didStartProvisionalLoad
2. didCommitProvisionalLoad
3. didCreateNewDocument
4. didCreateDocumentElement

BUG=232410
TBR=jochen,dcheng

Committed: https://crrev.com/b4d6bf98e54db861b8d9adc7642c47b1677b8f40
Cr-Commit-Position: refs/heads/master@{#388944}

[meacer, 2016-04-21 19:57:10]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:57:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910153002/1

[commit-bot: I haz the power, 2016-04-21 20:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:34:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meacer, 2016-04-21 20:57:04]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:57:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910153002/1

[commit-bot: I haz the power, 2016-04-21 23:14:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:41:18]

Description was changed from

==========
Reland of DocumentLoader should commit the load before creating a DocumentWriter

The current order of events in DocumentLoader causes an HTML parser to be
created via DocumentWriter::create before the load commits. This causes the HTML
parser to read a stale value for scriptEnabled setting in HTMLParserOptions if
the setting changes between page loads. This in turn breaks the rendering of
noscript tags.

This CL moves receivedFirstData call before DocumentWriter::create and
FrameLoader::didBeginDocument so that the load is committed before the HTML
parser is created and the correct scriptEnabled value is used by the parser. It
also moves creation of Content Security Policy and setting saved form data to a
new callback didInstallNewDocument.

NOTE: This also changes the order of callbacks in WebFrameClient.
The OLD order when loading a document was:
1. didStartProvisionalLoad
2. didCreateNewDocument
3. didCommitProvisionalLoad
4. didCreateDocumentElement

The NEW order is:
1. didStartProvisionalLoad
2. didCommitProvisionalLoad
3. didCreateNewDocument
4. didCreateDocumentElement

BUG=232410
TBR=jochen,dcheng
==========

to

==========
Reland of DocumentLoader should commit the load before creating a DocumentWriter

The current order of events in DocumentLoader causes an HTML parser to be
created via DocumentWriter::create before the load commits. This causes the HTML
parser to read a stale value for scriptEnabled setting in HTMLParserOptions if
the setting changes between page loads. This in turn breaks the rendering of
noscript tags.

This CL moves receivedFirstData call before DocumentWriter::create and
FrameLoader::didBeginDocument so that the load is committed before the HTML
parser is created and the correct scriptEnabled value is used by the parser. It
also moves creation of Content Security Policy and setting saved form data to a
new callback didInstallNewDocument.

NOTE: This also changes the order of callbacks in WebFrameClient.
The OLD order when loading a document was:
1. didStartProvisionalLoad
2. didCreateNewDocument
3. didCommitProvisionalLoad
4. didCreateDocumentElement

The NEW order is:
1. didStartProvisionalLoad
2. didCommitProvisionalLoad
3. didCreateNewDocument
4. didCreateDocumentElement

BUG=232410
TBR=jochen,dcheng

Committed: https://crrev.com/b4d6bf98e54db861b8d9adc7642c47b1677b8f40
Cr-Commit-Position: refs/heads/master@{#388944}
==========

[commit-bot: I haz the power, 2016-04-22 19:41:19]

Patchset 1 (id:??) landed as
https://crrev.com/b4d6bf98e54db861b8d9adc7642c47b1677b8f40
Cr-Commit-Position: refs/heads/master@{#388944}