ios/third_party/earl_grey/BUILD.gn - Issue 1910133002: [iOS/Mac/GN] The framework_bundle template should not force dependencies to link it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/third_party/earl_grey/BUILD.gn

Issue 1910133002: [iOS/Mac/GN] The framework_bundle template should not force dependencies to link it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/third_party/earl_grey/BUILD.gn

diff --git a/ios/third_party/earl_grey/BUILD.gn b/ios/third_party/earl_grey/BUILD.gn

index bf9c18c3563800c8e8a634b3b7aad1be587bae8e..ec2b1254d3ad309945a4b59a2092a1dba8aa13bf 100644

--- a/ios/third_party/earl_grey/BUILD.gn

+++ b/ios/third_party/earl_grey/BUILD.gn

@@ -238,7 +238,7 @@ ios_framework_bundle("earl_grey") {

"//third_party/google_toolbox_for_mac",

]

public_deps = [

- "//ios/third_party/ochamcrest",

+ "//ios/third_party/ochamcrest:ochamcrest+link",

]

libs = [

« no previous file with comments | « build/config/mac/rules.gni ('k') | no next file » | no next file with comments »