[iOS/Mac/GN] The framework_bundle template should not force dependencies to link it.

build/config/ios/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ios/ios_sdk.gni")
 import("//build/config/mac/rules.gni")
 
 # TODO(crbug.com/297668): refactor this template to extract common behaviour
 # between OS X and iOS bundle generation, then create a generic "app" template
 # that forward to "executable" on all platform except iOS/OS X.
 
 # Template to build an application bundle for iOS.
 #
 # This should be used instead of "executable" built-in target type on iOS.
 # As the template forward the generation of the application executable to
 # an "executable" target, all arguments supported by "executable" targets
 # are also supported by this template.

[brettw, 2016/04/21 20:27:55]

Can you carefully document the behavior here, listing the names of things you
would depend on and in what cases you would depend on them? Ideally this would
also have some background for non-iOS people like me about why one would need to
depend on this but not link to it.

[Robert Sesek, 2016/04/22 15:27:06]

I added this to the base framework_bundle docs since both Mac and iOS need to
refer to it (rather than copy/paste it both places).

 #
 # Arguments
 #
 #   output_name:
 #       (optional) string, name of the generated application, if omitted,
 #       defaults to the target_name.
 #
 #   extra_substitutions:
 #       (optional) list of string in "key=value" format, each value will
 #       be used as an additional variable substitution rule when generating
@@ skipping 297 matching lines @@
 
     group(_framework_headers_target) {
       deps = [
         ":$_compile_headers_map_target",
         ":$_copy_public_headers_target",
         ":$_create_module_map_target",
       ]
     }
   }
 
+  _framework_public_config = _target_name + "_ios_public_config"
+  config(_framework_public_config) {
+    visibility = [ ":$_framework_public_config" ]
+    if (defined(_public_headers)) {
+      common_flags = [ "-F" + rebase_path("$root_out_dir/.", root_out_dir) ]
+      cflags_objc = common_flags
+      cflags_objcc = common_flags
+    }
+
+    # The link settings are inherited from the framework_bundle config.
+  }
+
   framework_bundle(_framework_target) {
     forward_variables_from(invoker,
                            "*",
                            [
                              "output_name",
                              "public_headers",
                              "visibility",
                            ])
     output_name = _output_name
 
+    if (!defined(public_configs)) {
+      public_configs = []
+    }
+    public_configs += [ ":$_framework_public_config" ]
+
     if (defined(_public_headers)) {
-      visibility = [ ":$_target_name" ]
+      visibility = [
+        ":$_target_name",
+        ":$_target_name+link",
+      ]
       configs += [ ":$_headers_map_config" ]
 
       if (!defined(deps)) {
         deps = []
       }
       deps += [ ":$_framework_headers_target" ]
     } else {
-      forward_variables_from(invoker, [ "visibility" ])
+      if (defined(invoker.visibility)) {
+        visibility = invoker.visibility
+        visibility += [ ":$_target_name+link" ]
+      }
     }
   }
 
   if (defined(_public_headers)) {
     group(_target_name) {
       forward_variables_from(invoker,
                              [
                                "testonly",
-                               "visibility",
                                "public_configs",
                              ])
 
+      if (defined(invoker.visibility)) {
+        visibility = invoker.visibility
+        visibility += [ ":$_target_name+link" ]
+      }
+
       public_deps = [
         ":$_framework_target",
       ]
     }
+
+    group(_target_name + "+link") {
+      forward_variables_from(invoker,
+                             [
+                               "testonly",
+                               "visibility",
+                             ])
+      public_deps = [
+        ":$_framework_target+link",
+      ]
+    }
   }
 }