Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: src/compiler/ppc/instruction-selector-ppc.cc

Issue 1910123002: PPC64: [turbofan] Word32 loads should be unsigned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ppc/instruction-scheduler-ppc.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 #include "src/ppc/frames-ppc.h" 9 #include "src/ppc/frames-ppc.h"
10 10
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 case MachineRepresentation::kWord8: 183 case MachineRepresentation::kWord8:
184 opcode = load_rep.IsSigned() ? kPPC_LoadWordS8 : kPPC_LoadWordU8; 184 opcode = load_rep.IsSigned() ? kPPC_LoadWordS8 : kPPC_LoadWordU8;
185 break; 185 break;
186 case MachineRepresentation::kWord16: 186 case MachineRepresentation::kWord16:
187 opcode = load_rep.IsSigned() ? kPPC_LoadWordS16 : kPPC_LoadWordU16; 187 opcode = load_rep.IsSigned() ? kPPC_LoadWordS16 : kPPC_LoadWordU16;
188 break; 188 break;
189 #if !V8_TARGET_ARCH_PPC64 189 #if !V8_TARGET_ARCH_PPC64
190 case MachineRepresentation::kTagged: // Fall through. 190 case MachineRepresentation::kTagged: // Fall through.
191 #endif 191 #endif
192 case MachineRepresentation::kWord32: 192 case MachineRepresentation::kWord32:
193 opcode = kPPC_LoadWordS32; 193 opcode = kPPC_LoadWordU32;
194 #if V8_TARGET_ARCH_PPC64
195 // TODO(mbrandy): this applies to signed loads only (lwa)
196 mode = kInt16Imm_4ByteAligned;
197 #endif
198 break; 194 break;
199 #if V8_TARGET_ARCH_PPC64 195 #if V8_TARGET_ARCH_PPC64
200 case MachineRepresentation::kTagged: // Fall through. 196 case MachineRepresentation::kTagged: // Fall through.
201 case MachineRepresentation::kWord64: 197 case MachineRepresentation::kWord64:
202 opcode = kPPC_LoadWord64; 198 opcode = kPPC_LoadWord64;
203 mode = kInt16Imm_4ByteAligned; 199 mode = kInt16Imm_4ByteAligned;
204 break; 200 break;
205 #else 201 #else
206 case MachineRepresentation::kWord64: // Fall through. 202 case MachineRepresentation::kWord64: // Fall through.
207 #endif 203 #endif
(...skipping 1748 matching lines...) Expand 10 before | Expand all | Expand 10 after
1956 MachineOperatorBuilder::kFloat64RoundTruncate | 1952 MachineOperatorBuilder::kFloat64RoundTruncate |
1957 MachineOperatorBuilder::kFloat64RoundTiesAway | 1953 MachineOperatorBuilder::kFloat64RoundTiesAway |
1958 MachineOperatorBuilder::kWord32Popcnt | 1954 MachineOperatorBuilder::kWord32Popcnt |
1959 MachineOperatorBuilder::kWord64Popcnt; 1955 MachineOperatorBuilder::kWord64Popcnt;
1960 // We omit kWord32ShiftIsSafe as s[rl]w use 0x3f as a mask rather than 0x1f. 1956 // We omit kWord32ShiftIsSafe as s[rl]w use 0x3f as a mask rather than 0x1f.
1961 } 1957 }
1962 1958
1963 } // namespace compiler 1959 } // namespace compiler
1964 } // namespace internal 1960 } // namespace internal
1965 } // namespace v8 1961 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ppc/instruction-scheduler-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698