Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1910073002: Revert of Implement the basic testing infrastructure for FindRequestManager. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
paulmeyer, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement the basic testing infrastructure for FindRequestManager. (patchset #5 id:100001 of https://codereview.chromium.org/1891773002/ ) Reason for revert: All three of the FindRequestManagerTests failed on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/25938 Original issue's description: > Implement the basic testing infrastructure for FindRequestManager. > > This patch adds find_request_manager_browsertest.cc, along with a few find-in-page tests that can already be tested (though not yet with cross-process frames). There are also some new testing files and some small changes to FindRequestManager to facilitate testing. > > Design doc for multi-process find-in-page: https://docs.google.com/a/google.com/document/d/12S_6X2MWWLoyJslajcajL2ELU7zhodPxMOxa8Bg4Wg0/edit?usp=sharing > > BUG=457440 TBR=nasko@chromium.org,paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457440 Committed: https://crrev.com/ea191d3f445a566b2cb1d338d00cd43c6afee62e Cr-Commit-Position: refs/heads/master@{#388816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -363 lines) Patch
D content/browser/find_request_manager_browsertest.cc View 1 chunk +0 lines, -237 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/find_in_page.html View 1 chunk +0 lines, -13 lines 0 comments Download
D content/test/data/find_in_page_frame.html View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jbudorick
Created Revert of Implement the basic testing infrastructure for FindRequestManager.
4 years, 8 months ago (2016-04-21 18:17:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910073002/1
4 years, 8 months ago (2016-04-21 18:18:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 18:19:30 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:36:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea191d3f445a566b2cb1d338d00cd43c6afee62e
Cr-Commit-Position: refs/heads/master@{#388816}

Powered by Google App Engine
This is Rietveld 408576698