Store AVDACodecImage list in shared state, cleanup callers.

content/common/gpu/media/avda_codec_image.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/avda_codec_image.h"
 
 #include <string.h>
 
 #include <memory>
 
@@ skipping 21 matching lines @@
       surface_texture_(surface_texture),
       detach_surface_texture_on_destruction_(false),
       texture_(0) {
   // Default to a sane guess of "flip Y", just in case we can't get
   // the matrix on the first call.
   memset(gl_matrix_, 0, sizeof(gl_matrix_));
   gl_matrix_[0] = gl_matrix_[10] = gl_matrix_[15] = 1.0f;
   gl_matrix_[5] = -1.0f;
 }
 
-AVDACodecImage::~AVDACodecImage() {}
+AVDACodecImage::~AVDACodecImage() {
+  shared_state_->EraseImage(this);
+}
 
 void AVDACodecImage::Destroy(bool have_context) {}
 
 gfx::Size AVDACodecImage::GetSize() {
   return size_;
 }
 
 unsigned AVDACodecImage::GetInternalFormat() {
   return GL_RGBA;
 }
@@ skipping 112 matching lines @@
 }
 
 int AVDACodecImage::GetMediaCodecBufferIndex() const {
   return codec_buffer_index_;
 }
 
 void AVDACodecImage::SetSize(const gfx::Size& size) {
   size_ = size;
 }
 
 void AVDACodecImage::SetMediaCodec(media::MediaCodecBridge* codec) {

[liberato (no reviews please), 2016/04/21 23:39:54]

maybe rename to CodecChanged, since it also resets |codec_buffer_index_|.  it
has the same semantics as CodecChanged elsewhere, and also doesn't sound like a
simple setter.

[DaleCurtis, 2016/04/22 00:11:19]

Done.

   media_codec_ = codec;
+  codec_buffer_index_ = -1;

[watk, 2016/04/21 20:45:01]

kInvalidCodecBufferIndex?

[DaleCurtis, 2016/04/22 00:11:21]

Done.

 }
 
 void AVDACodecImage::SetTexture(gpu::gles2::Texture* texture) {
   texture_ = texture;
 }
 
 void AVDACodecImage::AttachSurfaceTextureToContext() {
   DCHECK(surface_texture_);
 
   // We assume that the currently bound texture is the intended one.
@@ skipping 47 matching lines @@
   }
 
   memcpy(matrix, gl_matrix_, sizeof(gl_matrix_));
 }
 
 bool AVDACodecImage::IsCodecBufferOutstanding() const {
   return codec_buffer_index_ != kInvalidCodecBufferIndex && media_codec_;
 }
 
 }  // namespace content