Issue 1910033002: Add warnings when async and async* functions declare a subtype of Future or Stream respectively (is…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1910033002: Add warnings when async and async* functions declare a subtype of Future or Stream respectively (is… (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson

Modified:
4 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add warnings when async and async* functions declare a subtype of Future or Stream respectively (issue 25854) R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/4367fd8800f842437353894a5d42c9499ccf8694

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -15 lines)			Patch
	M	pkg/analyzer/lib/src/generated/error_verifier.dart	View		1 chunk	+15 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/test/generated/static_type_warning_code_test.dart	View		5 chunks	+87 lines, -13 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Look carefully at the test cases to check whether I've correctly understood the desired behavior.

4 years, 8 months ago (2016-04-21 17:51:36 UTC) #2

Brian Wilkerson

4 years, 8 months ago (2016-04-21 18:03:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4367fd8800f842437353894a5d42c9499ccf8694 (presubmit successful).