Issue 191003011: Convert RenderLayerCompositor::RenderView code to use reference

Issue 191003011: Convert RenderLayerCompositor::RenderView code to use reference (Closed)

Created:
6 years, 9 months ago by maheshkk

Modified:
6 years, 9 months ago

Reviewers:
Inactive, ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@ref_3

Visibility:
Public.

More Reviews

Description

Convert RenderLayerCompositor::RenderView code to use reference RenderView is never null in RenderLayerCompositor and should be reference. Using references is safer for caller methods as well. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168866

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -73 lines)			Patch
M	Source/core/rendering/RenderView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View	43 chunks	+69 lines, -70 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/191003011/diff/1/Source/core/rendering/RenderView.h File Source/core/rendering/RenderView.h (right): https://codereview.chromium.org/191003011/diff/1/Source/core/rendering/RenderView.h#newcode43 Source/core/rendering/RenderView.h:43: WTF_MAKE_NONCOPYABLE(RenderView); Are you sure this is needed? I believe ...

6 years, 9 months ago (2014-03-10 19:03:12 UTC) #2

maheshkk

On 2014/03/10 19:03:12, Chris Dumez wrote: > https://codereview.chromium.org/191003011/diff/1/Source/core/rendering/RenderView.h > File Source/core/rendering/RenderView.h (right): > > https://codereview.chromium.org/191003011/diff/1/Source/core/rendering/RenderView.h#newcode43 ...

6 years, 9 months ago (2014-03-10 19:31:29 UTC) #3

Inactive

lgtm but please remove "Making RenderView non-copyable to avoid reference assignment mistakes." from your CL ...

6 years, 9 months ago (2014-03-10 19:34:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/191003011/20001

6 years, 9 months ago (2014-03-10 19:36:57 UTC) #6

Message was sent while issue was closed.

Change committed as 168866

Expand Messages | Collapse Messages