Move DeviceSensorEvent* h|cpp files to a common module

Move DeviceSensorEvent* h|cpp files to a common module

DeviceSensorEvent* h|cpp files resided under device_orientation as
device_orientation and motion were the only ones to use them. As more
Device Apis are added using the module system in Blink
(e.g. Ambient Light) we need to move these files to a common place (Source/core/frame) to
avoid any cross module dependency.


Encounted this issue while adding Ambient Light support ->
https://codereview.chromium.org/143823004/

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169270

[riju_, 2014-03-10 14:19:33]

Hi Adam,

PTAL. 

for reference:
https://codereview.chromium.org/143823004/diff/330001/Source/modules/deviceli...

[timvolodine, 2014-03-10 15:16:15]

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
File Source/modules/device_sensors_common/DeviceSensorEventController.cpp
(right):

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
Source/modules/device_sensors_common/DeviceSensorEventController.cpp:81: // Make
sure to fire the device motion data as soon as possible.
This should sound more general now, maybe just remove "device motion".

[riju_, 2014-03-10 15:40:18]

Thanks Tim for having a look.

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
File Source/modules/device_sensors_common/DeviceSensorEventController.cpp
(right):

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
Source/modules/device_sensors_common/DeviceSensorEventController.cpp:81: // Make
sure to fire the device motion data as soon as possible.
On 2014/03/10 15:16:15, timvolodine wrote:
> This should sound more general now, maybe just remove "device motion".

Done.

[riju_, 2014-03-10 15:40:18]

Thanks Tim for having a look.

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
File Source/modules/device_sensors_common/DeviceSensorEventController.cpp
(right):

https://codereview.chromium.org/191003009/diff/1/Source/modules/device_sensor...
Source/modules/device_sensors_common/DeviceSensorEventController.cpp:81: // Make
sure to fire the device motion data as soon as possible.
On 2014/03/10 15:16:15, timvolodine wrote:
> This should sound more general now, maybe just remove "device motion".

Done.

[riju_, 2014-03-11 13:25:53]

Hi Adam,  PTAL.

[abarth-chromium, 2014-03-11 18:27:56]

Common code needs to move out of the modules directory into either Source/core
or Source/platform.

[abarth-chromium, 2014-03-11 18:28:24]

It looks like you have dependencies on other core concepts, so you'll need to
move to some place like Source/core/frame.

[riju_, 2014-03-12 12:00:44]

On 2014/03/11 18:28:24, abarth wrote:
> It looks like you have dependencies on other core concepts, so you'll need to
> move to some place like Source/core/frame.

Done.

[abarth-chromium, 2014-03-12 19:27:22]

LGTM w/ files moved into Source/core/frame

https://codereview.chromium.org/191003009/diff/80001/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/191003009/diff/80001/Source/core/core.gypi#ne...
Source/core/core.gypi:1114:
'frame/device_sensors_common/DeviceSensorEventDispatcher.h',
You can just put these in frame/ directly.  There's no need to create a
subdirectory for these four files.

[riju_, 2014-03-13 11:16:35]

On 2014/03/12 19:27:22, abarth wrote:
> LGTM w/ files moved into Source/core/frame
> 
> https://codereview.chromium.org/191003009/diff/80001/Source/core/core.gypi
> File Source/core/core.gypi (right):
> 
>
https://codereview.chromium.org/191003009/diff/80001/Source/core/core.gypi#ne...
> Source/core/core.gypi:1114:
> 'frame/device_sensors_common/DeviceSensorEventDispatcher.h',
> You can just put these in frame/ directly.  There's no need to create a
> subdirectory for these four files.

Done.

Hi Tim, Can you please review/cq the rest of the changes ?

[timvolodine, 2014-03-13 12:05:13]

lgtm


with one comment

https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
File Source/core/frame/DeviceSensorEventDispatcher.cpp (right):

https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
Source/core/frame/DeviceSensorEventDispatcher.cpp:60: // 2. or after
didChangeDeviceMotion/Orientation has dispatched all events.
Actually we should change this as well since the referred methods are still in
the module. I think it should be something like:
"
2. or after events to all controllers have dispatched
(see e.g. DeviceOrientationDispatcher::didChangeDeviceOrientation).
This is to correctly handle the re-entrancy case when a controller is destroyed
while the events are still being dispatched.
"

[riju_, 2014-03-13 12:23:02]

thanks tim , cq ?

https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
File Source/core/frame/DeviceSensorEventDispatcher.cpp (right):

https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
Source/core/frame/DeviceSensorEventDispatcher.cpp:60: // 2. or after
didChangeDeviceMotion/Orientation has dispatched all events.
On 2014/03/13 12:05:13, timvolodine wrote:
> Actually we should change this as well since the referred methods are still in
> the module. I think it should be something like:
> "
> 2. or after events to all controllers have dispatched
> (see e.g. DeviceOrientationDispatcher::didChangeDeviceOrientation).
> This is to correctly handle the re-entrancy case when a controller is
destroyed
> while the events are still being dispatched.
> "

Done.

[timvolodine, 2014-03-13 14:11:00]

On 2014/03/13 12:23:02, riju_ wrote:
> thanks tim , cq ?
> 
>
https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
> File Source/core/frame/DeviceSensorEventDispatcher.cpp (right):
> 
>
https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
> Source/core/frame/DeviceSensorEventDispatcher.cpp:60: // 2. or after
> didChangeDeviceMotion/Orientation has dispatched all events.
> On 2014/03/13 12:05:13, timvolodine wrote:
> > Actually we should change this as well since the referred methods are still
in
> > the module. I think it should be something like:
> > "
> > 2. or after events to all controllers have dispatched
> > (see e.g. DeviceOrientationDispatcher::didChangeDeviceOrientation).
> > This is to correctly handle the re-entrancy case when a controller is
> destroyed
> > while the events are still being dispatched.
> > "
> 
> Done.

Thanks. Normally when you have all lgtms you can go ahead and commit. Are you
able to commit this patch?

[riju_, 2014-03-13 14:13:54]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:13:54]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:13:58]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[commit-bot: I haz the power, 2014-03-13 14:14:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/191003009/...

[riju_, 2014-03-13 14:14:03]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:05]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:07]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:16]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:17]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:24]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:27]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:39]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:44]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:51]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:14:55]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[commit-bot: I haz the power, 2014-03-13 14:14:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/191003009/...

[riju_, 2014-03-13 14:14:58]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:15:10]

The CQ bit was unchecked by rijubrata.bhaumik@intel.com

[riju_, 2014-03-13 14:16:23]

On 2014/03/13 14:11:00, timvolodine wrote:
> On 2014/03/13 12:23:02, riju_ wrote:
> > thanks tim , cq ?
> > 
> >
>
https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
> > File Source/core/frame/DeviceSensorEventDispatcher.cpp (right):
> > 
> >
>
https://codereview.chromium.org/191003009/diff/100001/Source/core/frame/Devic...
> > Source/core/frame/DeviceSensorEventDispatcher.cpp:60: // 2. or after
> > didChangeDeviceMotion/Orientation has dispatched all events.
> > On 2014/03/13 12:05:13, timvolodine wrote:
> > > Actually we should change this as well since the referred methods are
still
> in
> > > the module. I think it should be something like:
> > > "
> > > 2. or after events to all controllers have dispatched
> > > (see e.g. DeviceOrientationDispatcher::didChangeDeviceOrientation).
> > > This is to correctly handle the re-entrancy case when a controller is
> > destroyed
> > > while the events are still being dispatched.
> > > "
> > 
> > Done.
> 
> Thanks. Normally when you have all lgtms you can go ahead and commit. Are you
> able to commit this patch?

No, I am not a committer. Please click the cq button for me.

[timvolodine, 2014-03-13 14:47:22]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2014-03-13 14:47:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/191003009/...

[commit-bot: I haz the power, 2014-03-13 15:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 15:23:59]

Try jobs failed on following builders:
  tryserver.chromium on linux_blink

[riju_, 2014-03-14 11:24:40]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[commit-bot: I haz the power, 2014-03-14 11:24:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/191003009/...

[commit-bot: I haz the power, 2014-03-14 12:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 12:09:56]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[timvolodine, 2014-03-14 18:38:59]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2014-03-14 18:39:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/191003009/...

[commit-bot: I haz the power, 2014-03-14 20:13:23]

Change committed as 169270