Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191003002: Enable variations component unit tests on iOS. (Closed)

Created:
6 years, 9 months ago by Alexei Svitkine (slow)
Modified:
6 years, 9 months ago
Reviewers:
blundell
CC:
chromium-reviews
Visibility:
Public.

Description

Enable variations component unit tests on iOS. BUG=350421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255864

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/components_tests.gyp View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Alexei Svitkine (slow)
6 years, 9 months ago (2014-03-07 21:25:08 UTC) #1
blundell
LGTM, thanks!
6 years, 9 months ago (2014-03-08 08:51:36 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-08 08:51:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/191003002/20001
6 years, 9 months ago (2014-03-08 11:20:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:22:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234382
6 years, 9 months ago (2014-03-08 14:22:20 UTC) #6
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 9 months ago (2014-03-08 17:31:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/191003002/20001
6 years, 9 months ago (2014-03-08 17:31:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 18:15:57 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234509
6 years, 9 months ago (2014-03-08 18:15:58 UTC) #10
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-09 17:35:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/191003002/20001
6 years, 9 months ago (2014-03-09 17:35:52 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 17:59:15 UTC) #13
Message was sent while issue was closed. 
Change committed as 255864

Powered by Google App Engine
This is Rietveld 408576698