Invalidate all wallpaper cache if display configuration changed

chrome/browser/chromeos/login/wallpaper_manager.cc

Index: chrome/browser/chromeos/login/wallpaper_manager.cc
diff --git a/chrome/browser/chromeos/login/wallpaper_manager.cc b/chrome/browser/chromeos/login/wallpaper_manager.cc
index 14cfbf3c22b0b5206cf5ea356b61a9500154d361..75f5a769d3cbaa92b24611610d2fb8b41fc7bd8e 100644
--- a/chrome/browser/chromeos/login/wallpaper_manager.cc
+++ b/chrome/browser/chromeos/login/wallpaper_manager.cc
@@ -828,8 +828,9 @@ void WallpaperManager::SetWallpaperFromImageSkia(
   }
 }
 
-void WallpaperManager::UpdateWallpaper() {
-  ClearWallpaperCache();

[Nikita (slow), 2014/03/11 16:34:50]

What's the difference?

[bshe, 2014/03/11 22:52:35]

ClearWallpaperCache is probably misnamed. It will not clear the wallpaper cache
for logged in users in multi profile mode. This is preferred as we want a smooth
animation when switching users at multi profile mode.

However, if UpdateWallpaper is called after a large screen is hooked up. At
multi profile mode, we still need to invalidate all wallpaper caches. Otherwise,
when we switch user, the cached small resolution wallpaper is used. But we are
expecting large resolution wallpapers. And that's why the test failed.

If UpdateWallpaper is called by wallpaper private api, we don't want to
invalidate all the caches.

 
On 2014/03/11 16:34:50, Nikita Kostylev wrote:

+void WallpaperManager::UpdateWallpaper(bool clear_cache) {
+  if (clear_cache)
+    wallpaper_cache_.clear();
   current_wallpaper_path_.clear();
   // For GAIA login flow, the last_selected_user_ may not be set before user
   // login. If UpdateWallpaper is called at GAIA login screen, no wallpaper will