Source/core/editing/ApplyStyleCommand.cpp - Issue 190993002: ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 190993002: ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/execCommand/extracted-style-assert.html ('K') | « LayoutTests/editing/execCommand/extracted-style-assert-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ApplyStyleCommand.cpp

diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp

index cdeb208a108bb36141bb389e5fb3119a78e28513..0b9b5c4df12b8a26406cc42752aad801a7749774 100644

--- a/Source/core/editing/ApplyStyleCommand.cpp

+++ b/Source/core/editing/ApplyStyleCommand.cpp

@@ -892,8 +892,8 @@ bool ApplyStyleCommand::removeInlineStyleFromElement(EditingStyle* style, PassRe

if (isStyledInlineElementToRemove(element.get())) {

if (mode == RemoveNone)

return true;

- ASSERT(extractedStyle);

- extractedStyle->mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);

+ if (extractedStyle);

+ extractedStyle->mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);

removeNodePreservingChildren(element);

return true;

}

« LayoutTests/editing/execCommand/extracted-style-assert.html ('K') | « LayoutTests/editing/execCommand/extracted-style-assert-expected.txt ('k') | no next file » | no next file with comments »