Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 190993002: ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement (Closed)

Created:
6 years, 9 months ago by reni
Modified:
6 years, 9 months ago
Reviewers:
hayato
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set to default 0. This way we have to check its existence before the usage. Backported from my WebKit patch: http://trac.webkit.org/changeset/154439 R=hayato@chromium.org BUG=350414 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169948

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated test and expected file. #

Patch Set 3 : Fixed build fail. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A LayoutTests/editing/execCommand/extracted-style-assert.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/extracted-style-assert-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
reni
6 years, 9 months ago (2014-03-07 15:58:04 UTC) #1
hayato
LGTM https://codereview.chromium.org/190993002/diff/1/LayoutTests/editing/execCommand/extracted-style-assert.html File LayoutTests/editing/execCommand/extracted-style-assert.html (right): https://codereview.chromium.org/190993002/diff/1/LayoutTests/editing/execCommand/extracted-style-assert.html#newcode16 LayoutTests/editing/execCommand/extracted-style-assert.html:16: document.body.innerHTML = "PASS. WebKit didn't crash."; Nit: Could ...
6 years, 9 months ago (2014-03-10 04:59:08 UTC) #2
reni
Renamed 'WebKit' to 'Blink' in the test and in the expected file.
6 years, 9 months ago (2014-03-10 08:14:56 UTC) #3
hayato
On 2014/03/10 08:14:56, renata.hodovan wrote: > Renamed 'WebKit' to 'Blink' in the test and in ...
6 years, 9 months ago (2014-03-10 08:19:31 UTC) #4
reni
The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-10 08:25:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/190993002/20001
6 years, 9 months ago (2014-03-10 08:25:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 08:34:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-10 08:34:48 UTC) #8
reni
Typo fix (removing an extra ';').
6 years, 9 months ago (2014-03-10 08:49:05 UTC) #9
reni
On 2014/03/10 08:49:05, renata.hodovan wrote: > Typo fix (removing an extra ';'). I'm sorry, I ...
6 years, 9 months ago (2014-03-10 13:02:48 UTC) #10
reni
On 2014/03/10 13:02:48, renata.hodovan wrote: > On 2014/03/10 08:49:05, renata.hodovan wrote: > > Typo fix ...
6 years, 9 months ago (2014-03-17 10:02:14 UTC) #11
hayato
On 2014/03/17 10:02:14, renata.hodovan wrote: > On 2014/03/10 13:02:48, renata.hodovan wrote: > > On 2014/03/10 ...
6 years, 9 months ago (2014-03-25 04:45:59 UTC) #12
reni
The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-25 14:06:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/190993002/40001
6 years, 9 months ago (2014-03-25 14:06:56 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:10:23 UTC) #15
Message was sent while issue was closed.
Change committed as 169948

Powered by Google App Engine
This is Rietveld 408576698