[Interpreter] Use FastNewSloppyArguments when possible.

[Interpreter] Use FastNewSloppyArguments when possible.

Use the FastNewSloppyArgumentsStub in the interpreter when function doesn't have
duplicate parameters.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/c005029aa47f6e27d50e92a70f526f1651b18553
Cr-Commit-Position: refs/heads/master@{#35754}

[rmcilroy, 2016-04-21 11:03:14]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-04-21 11:03:34]

https://codereview.chromium.org/1909903003/diff/20001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/1909903003/diff/20001/src/x64/code-stubs-x64....
src/x64/code-stubs-x64.cc:4741: // TODO(bmeurer): Cleanup to match the
FastNewStrictArgumentsStub.
I didn't touch this TODO since I'm not sure how you were planning on cleaning
this up to match FastNewStrictArgumentsStub.

[rmcilroy, 2016-04-21 11:04:25]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org

[rmcilroy, 2016-04-21 11:04:26]

Benedkit, please take a look. If you are happy with this I'll port to the other
architectures.

[Benedikt Meurer, 2016-04-21 11:06:28]

I'd prefer to have this rewritten using the CodeStubAssembler (also the other
FastNew<Arguments>Stubs), but I'm also fine with this intermediate step.

[rmcilroy, 2016-04-22 09:20:24]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 09:20:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909903003/40001

[commit-bot: I haz the power, 2016-04-22 09:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 09:24:22]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)

[rmcilroy, 2016-04-22 09:25:45]

On 2016/04/21 11:06:28, Benedikt Meurer wrote:
> I'd prefer to have this rewritten using the CodeStubAssembler (also the other
> FastNew<Arguments>Stubs), but I'm also fine with this intermediate step.

I agree, long term these should be rewritten as CodeStubAssembler. I've added
ports, PTAL, thanks.

[rmcilroy, 2016-04-22 09:28:09]

Patchset #2 (id:40001) has been deleted

[rmcilroy, 2016-04-22 09:28:16]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 09:28:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909903003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909903003/60001

[commit-bot: I haz the power, 2016-04-22 10:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 10:20:45]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-04-25 08:47:19]

Ping?

[Benedikt Meurer, 2016-04-25 08:48:19]

Ah damnit, slipped thru again... LGTM as discussed.

[rmcilroy, 2016-04-25 08:58:24]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-04-25 08:58:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909903003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909903003/60001

[commit-bot: I haz the power, 2016-04-25 09:23:39]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-25 09:25:17]

Description was changed from

==========
[Interpreter] Use FastNewSloppyArguments when possible.

Use the FastNewSloppyArgumentsStub in the interpreter when function doesn't have
duplicate parameters.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Use FastNewSloppyArguments when possible.

Use the FastNewSloppyArgumentsStub in the interpreter when function doesn't have
duplicate parameters.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/c005029aa47f6e27d50e92a70f526f1651b18553
Cr-Commit-Position: refs/heads/master@{#35754}
==========

[commit-bot: I haz the power, 2016-04-25 09:25:18]

Patchset 2 (id:??) landed as
https://crrev.com/c005029aa47f6e27d50e92a70f526f1651b18553
Cr-Commit-Position: refs/heads/master@{#35754}