Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1909883002: [heap] Remove dead code from PagedSpace (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove dead code from PagedSpace BUG= Committed: https://crrev.com/01ca769c58eb9fb0991c0812096cb4655337cc4a Cr-Commit-Position: refs/heads/master@{#35774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/heap/spaces.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909883002/1
4 years, 8 months ago (2016-04-21 08:25:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 08:50:24 UTC) #4
Michael Lippautz
4 years, 8 months ago (2016-04-22 06:46:07 UTC) #6
ulan
lgtm
4 years, 8 months ago (2016-04-25 17:46:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909883002/1
4 years, 8 months ago (2016-04-25 17:48:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 18:18:35 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:18:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01ca769c58eb9fb0991c0812096cb4655337cc4a
Cr-Commit-Position: refs/heads/master@{#35774}

Powered by Google App Engine
This is Rietveld 408576698