Allow taking screen shot of a non child window which has delegate to paint.

Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot. This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.

Committed: https://crrev.com/5a296e8ea8a87a8506273f74225562b975f7b42c
Cr-Commit-Position: refs/heads/master@{#390559}

[oshima, 2016-04-23 00:46:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 00:47:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/40001

[commit-bot: I haz the power, 2016-04-23 01:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 01:06:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-23 01:31:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-04-23 01:31:57]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2016-04-23 01:34:10]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 01:34:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/120001

[commit-bot: I haz the power, 2016-04-23 02:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 02:16:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-26 22:00:21]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 22:00:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/240001

[commit-bot: I haz the power, 2016-04-26 22:43:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 22:43:24]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-04-27 01:02:37]

Patchset #1 (id:1) has been deleted

[oshima, 2016-04-27 01:02:41]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-04-27 01:02:44]

Patchset #4 (id:100001) has been deleted

[oshima, 2016-04-27 01:02:48]

Patchset #2 (id:60001) has been deleted

[oshima, 2016-04-27 01:02:52]

Patchset #1 (id:40001) has been deleted

[oshima, 2016-04-27 01:03:02]

Patchset #2 (id:120001) has been deleted

[oshima, 2016-04-27 01:03:07]

Patchset #5 (id:200001) has been deleted

[oshima, 2016-04-27 01:03:11]

Patchset #5 (id:220001) has been deleted

[oshima, 2016-04-27 01:03:15]

Patchset #3 (id:160001) has been deleted

[oshima, 2016-04-27 01:03:18]

Patchset #2 (id:140001) has been deleted

[oshima, 2016-04-27 01:19:04]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 01:19:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/260001

[commit-bot: I haz the power, 2016-04-27 01:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 01:24:55]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[oshima, 2016-04-27 17:00:42]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 17:01:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/280001

[commit-bot: I haz the power, 2016-04-27 17:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 17:52:37]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-04-27 18:12:42]

Patchset #1 (id:80001) has been deleted

[oshima, 2016-04-27 18:12:46]

Patchset #1 (id:180001) has been deleted

[oshima, 2016-04-27 18:12:50]

Patchset #1 (id:240001) has been deleted

[oshima, 2016-04-27 18:12:57]

Patchset #1 (id:260001) has been deleted

[oshima, 2016-04-27 18:16:26]

Description was changed from

==========
Screenshot

BUG=
==========

to

==========
Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot.
This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on
top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.
==========

[oshima, 2016-04-27 18:16:26]

oshima@chromium.org changed reviewers:
+ warx@chromium.org

[Qiang(Joe) Xu, 2016-04-27 18:38:07]

On 2016/04/27 18:16:36, oshima wrote:

lgtm

[oshima, 2016-04-29 00:33:34]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-04-29 00:33:36]

The patchset sent to the CQ was uploaded after l-g-t-m from warx@chromium.org
Link to the patchset: https://codereview.chromium.org/1909873002/#ps300001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-29 00:34:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909873002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909873002/300001

[commit-bot: I haz the power, 2016-04-29 01:32:37]

Description was changed from

==========
Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot.
This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on
top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.
==========

to

==========
Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot.
This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on
top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.
==========

[commit-bot: I haz the power, 2016-04-29 01:32:44]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2016-04-30 17:23:21]

Patchset 3 (id:??) landed as
https://crrev.com/5a296e8ea8a87a8506273f74225562b975f7b42c
Cr-Commit-Position: refs/heads/master@{#390559}

[commit-bot: I haz the power, 2016-04-30 17:58:48]

Description was changed from

==========
Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot.
This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on
top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.
==========

to

==========
Allow taking screen shot of a non child window which has delegate to paint.

* Rename PartialScreenshotController to ScreenshotController
* It selects active window by default and hitting return takes the screenshot.
This keeps the existing functionality to take screenshot w/o mouse
* The selected window is indicated by the half opaque gray area. It is shown on
top of all windows so that a user can see how big the window is.

BUG=481059
TEST=covered by unit tests. Also tested on device.

Committed: https://crrev.com/5a296e8ea8a87a8506273f74225562b975f7b42c
Cr-Commit-Position: refs/heads/master@{#390559}
==========

[oshima, 2016-05-21 01:27:09]

Patchset #3 (id:320001) has been deleted