Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/analyzer/lib/src/dart/ast/ast.dart

Issue 1909843002: Pull the 'keyword' property into Token. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/ast/ast.dart
diff --git a/pkg/analyzer/lib/src/dart/ast/ast.dart b/pkg/analyzer/lib/src/dart/ast/ast.dart
index 3e6d6200b4329b5278e0bcd114651cd95a7a5f42..f1f31647506b5281c2fb3cb4fcbe5ea1c6bf7a60 100644
--- a/pkg/analyzer/lib/src/dart/ast/ast.dart
+++ b/pkg/analyzer/lib/src/dart/ast/ast.dart
@@ -3228,14 +3228,10 @@ class DeclaredIdentifierImpl extends DeclarationImpl
}
@override
- bool get isConst =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.CONST;
+ bool get isConst => keyword?.keyword == Keyword.CONST;
@override
- bool get isFinal =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.FINAL;
+ bool get isFinal => keyword?.keyword == Keyword.FINAL;
@override
TypeName get type => _type;
@@ -4365,14 +4361,10 @@ class FieldFormalParameterImpl extends NormalFormalParameterImpl
}
@override
- bool get isConst =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.CONST;
+ bool get isConst => keyword?.keyword == Keyword.CONST;
@override
- bool get isFinal =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.FINAL;
+ bool get isFinal => keyword?.keyword == Keyword.FINAL;
@override
FormalParameterList get parameters => _parameters;
@@ -5037,14 +5029,10 @@ class FunctionDeclarationImpl extends NamedCompilationUnitMemberImpl
}
@override
- bool get isGetter =>
- propertyKeyword != null &&
- (propertyKeyword as KeywordToken).keyword == Keyword.GET;
+ bool get isGetter => propertyKeyword?.keyword == Keyword.GET;
@override
- bool get isSetter =>
- propertyKeyword != null &&
- (propertyKeyword as KeywordToken).keyword == Keyword.SET;
+ bool get isSetter => propertyKeyword?.keyword == Keyword.SET;
@override
TypeName get returnType => _returnType;
@@ -6126,9 +6114,7 @@ class InstanceCreationExpressionImpl extends ExpressionImpl
Token get endToken => _argumentList.endToken;
@override
- bool get isConst =>
- keyword is KeywordToken &&
- (keyword as KeywordToken).keyword == Keyword.CONST;
+ bool get isConst => keyword?.keyword == Keyword.CONST;
@override
int get precedence => 16;
@@ -7125,22 +7111,16 @@ class MethodDeclarationImpl extends ClassMemberImpl
}
@override
- bool get isGetter =>
- propertyKeyword != null &&
- (propertyKeyword as KeywordToken).keyword == Keyword.GET;
+ bool get isGetter => propertyKeyword?.keyword == Keyword.GET;
@override
bool get isOperator => operatorKeyword != null;
@override
- bool get isSetter =>
- propertyKeyword != null &&
- (propertyKeyword as KeywordToken).keyword == Keyword.SET;
+ bool get isSetter => propertyKeyword?.keyword == Keyword.SET;
@override
- bool get isStatic =>
- modifierKeyword != null &&
- (modifierKeyword as KeywordToken).keyword == Keyword.STATIC;
+ bool get isStatic => modifierKeyword?.keyword == Keyword.STATIC;
@override
SimpleIdentifier get name => _name;
@@ -8844,14 +8824,10 @@ class SimpleFormalParameterImpl extends NormalFormalParameterImpl
Token get endToken => identifier.endToken;
@override
- bool get isConst =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.CONST;
+ bool get isConst => keyword?.keyword == Keyword.CONST;
@override
- bool get isFinal =>
- (keyword is KeywordToken) &&
- (keyword as KeywordToken).keyword == Keyword.FINAL;
+ bool get isFinal => keyword?.keyword == Keyword.FINAL;
@override
TypeName get type => _type;
@@ -10724,14 +10700,10 @@ class VariableDeclarationListImpl extends AnnotatedNodeImpl
}
@override
- bool get isConst =>
- keyword is KeywordToken &&
- (keyword as KeywordToken).keyword == Keyword.CONST;
+ bool get isConst => keyword?.keyword == Keyword.CONST;
@override
- bool get isFinal =>
- keyword is KeywordToken &&
- (keyword as KeywordToken).keyword == Keyword.FINAL;
+ bool get isFinal => keyword?.keyword == Keyword.FINAL;
@override
TypeName get type => _type;

Powered by Google App Engine
This is Rietveld 408576698