Pull the 'keyword' property into Token.

Pull the 'keyword' property into Token.

So, we can use it without casting to KeywordToken.
This gives small, but noticable performanace boost, about 4% on hot VM.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/305f1f538c7830021ccfebcced52ac186106e7ff

[Brian Wilkerson, 2016-04-21 13:41:37]

Thank you! I've been wanting to do that for a long time. LGTM.

https://codereview.chromium.org/1909843002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/1909843002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/util.dart:1415: * Return the
first keyword [Token] with given [Keyword], may be `null` if
nit: Personally, I'd rewrite this as

Return the first token in the list of [tokens] representing the given [keyword],
or `null` if there is no such token.

IMO it's better to refer to the parameters than the types of the parameters in
documentation.

[scheglov, 2016-04-21 15:23:51]

Description was changed from

==========
Pull the 'keyword' property into Token.

So, we can use it without casting to KeywordToken.
This gives small, but noticable performanace boost, about 4% on hot VM.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Pull the 'keyword' property into Token.

So, we can use it without casting to KeywordToken.
This gives small, but noticable performanace boost, about 4% on hot VM.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/305f1f538c7830021ccfebcced52ac186106e7ff
==========

[scheglov, 2016-04-21 15:23:52]

Committed patchset #1 (id:1) manually as
305f1f538c7830021ccfebcced52ac186106e7ff (presubmit successful).