Issue 1909803002: Add per thread heap enabled MarkingVisitorImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1909803002: Add per thread heap enabled MarkingVisitorImpl

Created:
4 years, 8 months ago by keishi

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add per thread heap enabled MarkingVisitorImpl Add bool template to MarkingVisitorImpl so we can use ThreadHeap::main() for per thread heap disabled threads. Making InlinedGlobalMarkingVisitor support per thread heap enabled mode is difficult so this uses ThreadLocalMarkingMode to disable it for per thread heap enabled threads. BUG=591606

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -36 lines)			Patch
M	third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/MarkingVisitor.h	View	1	2 chunks	+20 lines, -13 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h	View	1 2	6 chunks	+33 lines, -7 lines	0 comments	Download
M	third_party/WebKit/Source/platform/heap/Visitor.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/heap/Visitor.cpp	View		1 chunk	+30 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909803002/20001

4 years, 7 months ago (2016-05-11 07:24:20 UTC) #2

commit-bot: I haz the power

4 years, 7 months ago (2016-05-11 10:12:31 UTC) #4

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages