Source/modules/webaudio/AudioBuffer.cpp - Issue 190973010: Remove unnecessary attribute "gain" in AudioBuffer and AudioBufferSourceNode interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioBuffer.cpp

Issue 190973010: Remove unnecessary attribute "gain" in AudioBuffer and AudioBufferSourceNode interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Combine with removing gains from AudioBuffer and AudioBufferSourceNode Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/AudioBuffer.cpp

diff --git a/Source/modules/webaudio/AudioBuffer.cpp b/Source/modules/webaudio/AudioBuffer.cpp

index 7d7a4637f72525a6e934ffe8da9bf9fa4bc9c9d5..52a18a3b88044e44d0aca021b10e884760f352db 100644

--- a/Source/modules/webaudio/AudioBuffer.cpp

+++ b/Source/modules/webaudio/AudioBuffer.cpp

@@ -82,8 +82,7 @@ bool AudioBuffer::createdSuccessfully(unsigned desiredNumberOfChannels) const

}

AudioBuffer::AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate)

- : m_gain(1.0)

- , m_sampleRate(sampleRate)

+ : m_sampleRate(sampleRate)

, m_length(numberOfFrames)

{

ScriptWrappable::init(this);

@@ -103,8 +102,7 @@ AudioBuffer::AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float

}

AudioBuffer::AudioBuffer(AudioBus* bus)

- : m_gain(1.0)

- , m_sampleRate(bus->sampleRate())

+ : m_sampleRate(bus->sampleRate())

, m_length(bus->length())

{

ScriptWrappable::init(this);

« no previous file with comments | « Source/modules/webaudio/AudioBuffer.h ('k') | Source/modules/webaudio/AudioBuffer.idl » ('j') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('J')