Source/modules/webaudio/AudioBuffer.idl - Issue 190973010: Remove unnecessary attribute "gain" in AudioBuffer and AudioBufferSourceNode interfaces

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/webaudio/AudioBuffer.idl

Issue 190973010: Remove unnecessary attribute "gain" in AudioBuffer and AudioBufferSourceNode interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Combine with removing gains from AudioBuffer and AudioBufferSourceNode Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 15 matching lines...) Expand all Loading...
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

27 */	27 */

28	28

29 [	29 [

30 Conditional=WEB_AUDIO	30 Conditional=WEB_AUDIO

31 ] interface AudioBuffer {	31 ] interface AudioBuffer {

32 readonly attribute long length; // in sample-frames	32 readonly attribute long length; // in sample-frames

33 readonly attribute double duration; // in seconds	33 readonly attribute double duration; // in seconds

34 readonly attribute float sampleRate; // in sample-frames per second	34 readonly attribute float sampleRate; // in sample-frames per second

35	35

36 attribute float gain; // linear gain (default 1.0)

37

38 // Channel access	36 // Channel access

39 readonly attribute unsigned long numberOfChannels;	37 readonly attribute unsigned long numberOfChannels;

40 [RaisesException] Float32Array getChannelData(unsigned long channelIndex);	38 [RaisesException] Float32Array getChannelData(unsigned long channelIndex);

41 };	39 };

OLD	NEW