Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: Source/modules/webaudio/AudioBuffer.h

Issue 190973010: Remove unnecessary attribute "gain" in AudioBuffer and AudioBufferSourceNode interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Combine with removing gains from AudioBuffer and AudioBufferSourceNode Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 size_t length() const { return m_length; } 52 size_t length() const { return m_length; }
53 double duration() const { return length() / static_cast<double>(sampleRate() ); } 53 double duration() const { return length() / static_cast<double>(sampleRate() ); }
54 float sampleRate() const { return m_sampleRate; } 54 float sampleRate() const { return m_sampleRate; }
55 55
56 // Channel data access 56 // Channel data access
57 unsigned numberOfChannels() const { return m_channels.size(); } 57 unsigned numberOfChannels() const { return m_channels.size(); }
58 PassRefPtr<Float32Array> getChannelData(unsigned channelIndex, ExceptionStat e&); 58 PassRefPtr<Float32Array> getChannelData(unsigned channelIndex, ExceptionStat e&);
59 Float32Array* getChannelData(unsigned channelIndex); 59 Float32Array* getChannelData(unsigned channelIndex);
60 void zero(); 60 void zero();
61 61
62 // Scalar gain
63 double gain() const { return m_gain; }
64 void setGain(double gain) { m_gain = gain; }
65
66 static float minAllowedSampleRate(); 62 static float minAllowedSampleRate();
67 static float maxAllowedSampleRate(); 63 static float maxAllowedSampleRate();
68 protected: 64 protected:
69 AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRa te); 65 AudioBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRa te);
70 explicit AudioBuffer(AudioBus*); 66 explicit AudioBuffer(AudioBus*);
71 bool createdSuccessfully(unsigned desiredNumberOfChannels) const; 67 bool createdSuccessfully(unsigned desiredNumberOfChannels) const;
72 68
73 double m_gain; // scalar gain
74 float m_sampleRate; 69 float m_sampleRate;
75 size_t m_length; 70 size_t m_length;
76 71
77 Vector<RefPtr<Float32Array> > m_channels; 72 Vector<RefPtr<Float32Array> > m_channels;
78 }; 73 };
79 74
80 } // namespace WebCore 75 } // namespace WebCore
81 76
82 #endif // AudioBuffer_h 77 #endif // AudioBuffer_h
OLDNEW
« no previous file with comments | « no previous file | Source/modules/webaudio/AudioBuffer.cpp » ('j') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698