Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190973008: Mojo: Remove implicit scoped_refptr<T> -> T* conversions in mojo/. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Remove implicit scoped_refptr<T> -> T* conversions in mojo/. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M mojo/common/handle_watcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/message_in_transit.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-08 02:56:17 UTC) #1
yzshen1
lgtm
6 years, 9 months ago (2014-03-08 03:21:22 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-08 22:54:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/190973008/1
6 years, 9 months ago (2014-03-08 22:54:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 23:49:31 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234628
6 years, 9 months ago (2014-03-08 23:49:32 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-09 00:10:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/190973008/1
6 years, 9 months ago (2014-03-09 00:11:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 00:47:17 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234653
6 years, 9 months ago (2014-03-09 00:47:18 UTC) #10
viettrungluu
6 years, 9 months ago (2014-03-09 00:49:22 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 manually as r255800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698