Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1909713002: Updating install-build-deps.sh to fix dependency issues in wily (Closed)

Created:
4 years, 8 months ago by friedman
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, friedman1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating install-build-deps.sh to fix dependency issues in wily Here's my testing: % /tmp/case_test.sh precise dummy-package_1 dummy-package_2 % /tmp/case_test.sh trusty dummy-package_1 dummy-package_2 g++-4.8-multilib-arm-linux-gnueabihf gcc-4.8-multilib-arm-linux-gnueabihf % /tmp/case_test.sh wily dummy-package_1 dummy-package_2 g++-5-multilib-arm-linux-gnueabihf gcc-5-multilib-arm-linux-gnueabihf gcc-arm-linux-gnueabihf % cat /tmp/case_test.sh lsb_release=$1 arm_list="dummy-package_1 dummy-package_2" case $lsb_release in trusty) arm_list+=" g++-4.8-multilib-arm-linux-gnueabihf gcc-4.8-multilib-arm-linux-gnueabihf" ;; wily) arm_list+=" g++-5-multilib-arm-linux-gnueabihf gcc-5-multilib-arm-linux-gnueabihf gcc-arm-linux-gnueabihf" ;; esac echo $arm_list R=dpranke@chromium.org BUG=435056 Committed: https://crrev.com/bf8b90af01f4e821a56d9c4a3dcfd908ecaa5837 Cr-Commit-Position: refs/heads/master@{#388652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M build/install-build-deps.sh View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
friedman
4 years, 8 months ago (2016-04-20 23:23:23 UTC) #1
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-20 23:56:56 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-20 23:57:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909713002/1
4 years, 8 months ago (2016-04-20 23:58:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 01:15:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf8b90af01f4e821a56d9c4a3dcfd908ecaa5837
Cr-Commit-Position: refs/heads/master@{#388652}

Powered by Google App Engine
This is Rietveld 408576698