Source/core/rendering/svg/RenderSVGForeignObject.cpp - Issue 19097005: Remove one SVG animated type special case from the bindings generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGForeignObject.cpp

Issue 19097005: Remove one SVG animated type special case from the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix the regressions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/svg/RenderSVGEllipse.cpp ('k') | Source/core/rendering/svg/RenderSVGImage.cpp » ('j') | Source/core/svg/SVGTextContentElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGForeignObject.cpp

diff --git a/Source/core/rendering/svg/RenderSVGForeignObject.cpp b/Source/core/rendering/svg/RenderSVGForeignObject.cpp

index e6a16c8330bd85dbc52949eb932285db2dc3cd39..632e80509d4960de2970dbbeecdc0ae9c4a485f8 100644

--- a/Source/core/rendering/svg/RenderSVGForeignObject.cpp

+++ b/Source/core/rendering/svg/RenderSVGForeignObject.cpp

@@ -137,8 +137,8 @@ void RenderSVGForeignObject::layout()

// Cache viewport boundaries

SVGLengthContext lengthContext(foreign);

- FloatPoint viewportLocation(foreign->x().value(lengthContext), foreign->y().value(lengthContext));

- m_viewport = FloatRect(viewportLocation, FloatSize(foreign->width().value(lengthContext), foreign->height().value(lengthContext)));

+ FloatPoint viewportLocation(foreign->xCurrentValue().value(lengthContext), foreign->yCurrentValue().value(lengthContext));

+ m_viewport = FloatRect(viewportLocation, FloatSize(foreign->widthCurrentValue().value(lengthContext), foreign->heightCurrentValue().value(lengthContext)));

if (!updateCachedBoundariesInParents)

updateCachedBoundariesInParents = oldViewport != m_viewport;

« no previous file with comments | « Source/core/rendering/svg/RenderSVGEllipse.cpp ('k') | Source/core/rendering/svg/RenderSVGImage.cpp » ('j') | Source/core/svg/SVGTextContentElement.h » ('J')