Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 19097005: Remove one SVG animated type special case from the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix the regressions Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSCursorImageValue.cpp » ('j') | Source/core/svg/SVGTextContentElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index d427ea273b9b12641e4d6ab7cb0f7f3ba7b8f337..b06bfc4f7d054b544f6307438074d0e9903fc3b0 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5845,10 +5845,6 @@ sub AttributeNameForGetterAndSetter
# To solve this issue the SVGAElement method was renamed to "svgTarget", take care of that when calling this method.
$attributeName = "svgTarget" if $attributeName eq "target" and $attributeType eq "SVGAnimatedString";
- # SVG animated types need to use a special attribute name.
- # The rest of the special casing for SVG animated types is handled in the language-specific code generators.
- $attributeName .= "Animated" if IsSVGAnimatedType($attributeType);
-
return $attributeName;
}
« no previous file with comments | « no previous file | Source/core/css/CSSCursorImageValue.cpp » ('j') | Source/core/svg/SVGTextContentElement.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698