Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 19097005: Remove one SVG animated type special case from the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix the regressions Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 SVGGraphicsElement::svgAttributeChanged(attrName); 128 SVGGraphicsElement::svgAttributeChanged(attrName);
129 return; 129 return;
130 } 130 }
131 131
132 SVGElementInstance::InvalidationGuard invalidationGuard(this); 132 SVGElementInstance::InvalidationGuard invalidationGuard(this);
133 133
134 // Unlike other SVG*Element classes, SVGAElement only listens to SVGURIRefer ence changes 134 // Unlike other SVG*Element classes, SVGAElement only listens to SVGURIRefer ence changes
135 // as none of the other properties changes the linking behaviour for our <a> element. 135 // as none of the other properties changes the linking behaviour for our <a> element.
136 if (SVGURIReference::isKnownAttribute(attrName)) { 136 if (SVGURIReference::isKnownAttribute(attrName)) {
137 bool wasLink = isLink(); 137 bool wasLink = isLink();
138 setIsLink(!href().isNull()); 138 setIsLink(!hrefCurrentValue().isNull());
139 139
140 if (wasLink != isLink()) 140 if (wasLink != isLink())
141 setNeedsStyleRecalc(); 141 setNeedsStyleRecalc();
142 } 142 }
143 } 143 }
144 144
145 RenderObject* SVGAElement::createRenderer(RenderStyle*) 145 RenderObject* SVGAElement::createRenderer(RenderStyle*)
146 { 146 {
147 if (parentNode() && parentNode()->isSVGElement() && toSVGElement(parentNode( ))->isTextContent()) 147 if (parentNode() && parentNode()->isSVGElement() && toSVGElement(parentNode( ))->isTextContent())
148 return new (document()->renderArena()) RenderSVGInline(this); 148 return new (document()->renderArena()) RenderSVGInline(this);
149 149
150 return new (document()->renderArena()) RenderSVGTransformableContainer(this) ; 150 return new (document()->renderArena()) RenderSVGTransformableContainer(this) ;
151 } 151 }
152 152
153 void SVGAElement::defaultEventHandler(Event* event) 153 void SVGAElement::defaultEventHandler(Event* event)
154 { 154 {
155 if (isLink()) { 155 if (isLink()) {
156 if (focused() && isEnterKeyKeydownEvent(event)) { 156 if (focused() && isEnterKeyKeydownEvent(event)) {
157 event->setDefaultHandled(); 157 event->setDefaultHandled();
158 dispatchSimulatedClick(event); 158 dispatchSimulatedClick(event);
159 return; 159 return;
160 } 160 }
161 161
162 if (isLinkClick(event)) { 162 if (isLinkClick(event)) {
163 String url = stripLeadingAndTrailingHTMLSpaces(href()); 163 String url = stripLeadingAndTrailingHTMLSpaces(hrefCurrentValue());
164 164
165 if (url[0] == '#') { 165 if (url[0] == '#') {
166 Element* targetElement = treeScope()->getElementById(url.substri ng(1)); 166 Element* targetElement = treeScope()->getElementById(url.substri ng(1));
167 if (SVGSMILElement::isSMILElement(targetElement)) { 167 if (SVGSMILElement::isSMILElement(targetElement)) {
168 static_cast<SVGSMILElement*>(targetElement)->beginByLinkActi vation(); 168 static_cast<SVGSMILElement*>(targetElement)->beginByLinkActi vation();
169 event->setDefaultHandled(); 169 event->setDefaultHandled();
170 return; 170 return;
171 } 171 }
172 // Only allow navigation to internal <view> anchors. 172 // Only allow navigation to internal <view> anchors.
173 if (targetElement && !targetElement->hasTagName(SVGNames::viewTa g)) 173 if (targetElement && !targetElement->hasTagName(SVGNames::viewTa g))
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 // The 'a' element may contain any element that its parent may contain, exce pt itself. 234 // The 'a' element may contain any element that its parent may contain, exce pt itself.
235 if (childContext.node()->hasTagName(SVGNames::aTag)) 235 if (childContext.node()->hasTagName(SVGNames::aTag))
236 return false; 236 return false;
237 if (parentNode() && parentNode()->isSVGElement()) 237 if (parentNode() && parentNode()->isSVGElement())
238 return parentNode()->childShouldCreateRenderer(childContext); 238 return parentNode()->childShouldCreateRenderer(childContext);
239 239
240 return SVGElement::childShouldCreateRenderer(childContext); 240 return SVGElement::childShouldCreateRenderer(childContext);
241 } 241 }
242 242
243 } // namespace WebCore 243 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698