Chromium Code Reviews| Index: tests/language/prefix16_test.dart |
| diff --git a/tests/language/prefix16_test.dart b/tests/language/prefix16_test.dart |
| index 4fca6b0c0c386aaac1090e0d3ea45e25b0e602cc..43c036f35a0e25195987de057890320ed8f60aaa 100644 |
| --- a/tests/language/prefix16_test.dart |
| +++ b/tests/language/prefix16_test.dart |
| @@ -2,11 +2,9 @@ |
| // for details. All rights reserved. Use of this source code is governed by a |
| // BSD-style license that can be found in the LICENSE file. |
| // |
| -// Unresolved imported symbols are handled differently in production mode and |
| -// check modes. In this test, the function myFunc is malformed, because |
| +// Unresolved imported symbols are treated as dynamic |
| +// In this test, the function myFunc contains malformed types because |
| // lib12.Library13 is not resolved. |
| -// In checked mode, the assignment type check throws a run time type error. |
| -// In production, no assignment type checks are performed. |
| library Prefix16NegativeTest.dart; |
| import "package:expect/expect.dart"; |
| @@ -28,6 +26,7 @@ main() { |
| { |
| bool got_type_error = false; |
| try { |
| + // Malformed myFunc treated as (dynamic) => dynamic. |
|
karlklose
2013/07/19 11:45:40
Do we have tests for functions with malformed and
Johnni Winther
2013/07/29 09:59:48
Extended this test.
|
| myFunc i = 0; |
| } on TypeError catch (error) { |
| got_type_error = true; |
| @@ -38,12 +37,12 @@ main() { |
| { |
| bool got_type_error = false; |
| try { |
| - // In production mode, malformed myFunc is mapped to (dynamic) => dynamic. |
| + // Malformed myFunc treated as (dynamic) => dynamic. |
| Expect.isTrue(((int x) => x) is myFunc); |
| } on TypeError catch (error) { |
| got_type_error = true; |
| } |
| // Type error in checked mode only. |
|
karlklose
2013/07/19 11:45:40
Update comment. You could also fail directly in t
Johnni Winther
2013/07/29 09:59:48
Done.
|
| - Expect.isTrue(got_type_error == isCheckedMode()); |
| + Expect.isFalse(got_type_error); |
| } |
| } |