[interpreter] Fix stack trace printers for debugging.

[interpreter] Fix stack trace printers for debugging.

This is pretty useful when debugging. There is no easy way to find the
bytecode arrays on the stack.

R=mstarzinger@chromium.org

Committed: https://crrev.com/fa8bac650f5264554d65cef3a67e12b81a1adfd5
Cr-Commit-Position: refs/heads/master@{#35712}

[Yang, 2016-04-21 13:00:53]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 13:01:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909663005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909663005/1

[commit-bot: I haz the power, 2016-04-21 13:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 13:30:23]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-04-21 17:05:18]

LGTM. More debugging output is always good. Just nits.

https://codereview.chromium.org/1909663005/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1909663005/diff/1/src/frames.cc#newcode1414
src/frames.cc:1414: accumulator->Add(":%d] [pc=%p]", line, pc);
nit: Doesn't this print the line number twice now?

https://codereview.chromium.org/1909663005/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1909663005/diff/1/src/isolate.cc#newcode1331
src/isolate.cc:1331: if (frame->is_java_script() &&
nit: Just "frame->is_interpreted()" is sufficient. No need to cast.

[Yang, 2016-04-22 05:03:39]

https://codereview.chromium.org/1909663005/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1909663005/diff/1/src/frames.cc#newcode1414
src/frames.cc:1414: accumulator->Add(":%d] [pc=%p]", line, pc);
On 2016/04/21 17:05:18, Michael Starzinger wrote:
> nit: Doesn't this print the line number twice now?

You are right. Fixed.

https://codereview.chromium.org/1909663005/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1909663005/diff/1/src/isolate.cc#newcode1331
src/isolate.cc:1331: if (frame->is_java_script() &&
On 2016/04/21 17:05:18, Michael Starzinger wrote:
> nit: Just "frame->is_interpreted()" is sufficient. No need to cast.

Done.

[Yang, 2016-04-22 05:03:42]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-22 05:03:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1909663005/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-04-22 05:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909663005/20001

[commit-bot: I haz the power, 2016-04-22 07:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:06:06]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/565)

[Michael Achenbach, 2016-04-22 07:31:44]

Please upload a new (empty) patchset and queue that one (see
http://crbug.com/605846). Sorry for the inconvenience.

[Yang, 2016-04-22 07:44:24]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-22 07:44:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1909663005/#ps40001
(title: "empty patch set as per comment")

[commit-bot: I haz the power, 2016-04-22 07:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909663005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909663005/40001

[commit-bot: I haz the power, 2016-04-22 08:08:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:15:00]

Description was changed from

==========
[interpreter] Fix stack trace printers for debugging.

This is pretty useful when debugging. There is no easy way to find the
bytecode arrays on the stack.

R=mstarzinger@chromium.org
==========

to

==========
[interpreter] Fix stack trace printers for debugging.

This is pretty useful when debugging. There is no easy way to find the
bytecode arrays on the stack.

R=mstarzinger@chromium.org

Committed: https://crrev.com/fa8bac650f5264554d65cef3a67e12b81a1adfd5
Cr-Commit-Position: refs/heads/master@{#35712}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:01]

Patchset 3 (id:??) landed as
https://crrev.com/fa8bac650f5264554d65cef3a67e12b81a1adfd5
Cr-Commit-Position: refs/heads/master@{#35712}