chrome/app/generated_resources.grd - Issue 1909663004: Desktop Capture Picker New UI: Non Mac Structure Change

Unified Diff: chrome/app/generated_resources.grd

Issue 1909663004: Desktop Capture Picker New UI: Non Mac Structure Change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 97758e22caf46e695decc08e4005853472b36b3c..3998191dcc468a2d7bab45257b6e940c51455daf 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -13546,11 +13546,14 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex

To share audio, select a tab.

</message>

- <message name="IDS_DESKTOP_MEDIA_PICKER_AUDIO_SHARE_TOOLTIP_WINDOW" desc="Tooltip text for the checkbox on the window picker dialog, explaining why the checkbox to share audio is disabled">

- To share audio, select a tab or entire screen.

+ <message name="IDS_DESKTOP_MEDIA_PICKER_SOURCE_TYPE_SCREEN" desc="Text for the button on the window picker dialog, clicking which takes one to full screen sharing">

msw 2016/04/22 22:19:56 nit: say "clicking the button", not "clicking whic

+ YOUR ENTIRE SCREEN

msw 2016/04/22 22:19:56 Why are these in ALL CAPS? Should our UI to be yel

qiangchen 2016/04/25 17:27:00 I just follow the design from UX people.

msw 2016/04/25 17:40:20 Push back on this, it's unusual. I posted on the b

</message>

- <message name="IDS_DESKTOP_MEDIA_PICKER_AUDIO_SHARE_TOOLTIP_NONE" desc="Tooltip text for the checkbox on the window picker dialog, explaining why the checkbox for audio sharing is disabled">

- Please select what to share first.

+ <message name="IDS_DESKTOP_MEDIA_PICKER_SOURCE_TYPE_WINDOW" desc="Text for the button on the window picker dialog, clicking which takes one to window sharing">

+ APPLICATION WINDOW

+ </message>

+ <message name="IDS_DESKTOP_MEDIA_PICKER_SOURCE_TYPE_TAB" desc="Text for the button on the window picker dialog, clicking which takes one to tab sharing">

+ CHROME TAB

msw 2016/04/22 22:19:56 Shouldn't we insert the actual product string here

qiangchen 2016/04/25 17:27:00 Hmm, how about showing "Chrome tab" for official b

msw 2016/04/25 17:40:21 Yes, use ids_short_product_name or similar; Chromi

</message>

Entire screen

« no previous file with comments | « no previous file | chrome/browser/ui/views/desktop_media_picker_views.h » ('j') | chrome/browser/ui/views/desktop_media_picker_views.h » ('J')