tools/dom/templates/html/impl/impl_Element.darttemplate - Issue 1909613003: Revert "Remove the generics from _FrozenElementList: causes checked mode failures"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 1909613003: Revert "Remove the generics from _FrozenElementList: causes checked mode failures" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | tools/dom/templates/html/impl/impl_IDBFactory.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_Element.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate

index 599eaf896458b524d153375fec5a1f0640d756f6..a2ea4fa5a45d8f68655e5b9cdac8f28e036ea924 100644

--- a/tools/dom/templates/html/impl/impl_Element.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate

@@ -264,8 +264,8 @@ $!STREAM_GETTER_SIGNATURES

// declared to return `ElementList`. This provides all the static analysis

// benefit so there is no need for this class have a constrained type parameter.

-class _FrozenElementList extends ListBase

- implements ElementList, NodeListWrapper {

+class _FrozenElementList extends ListBase<Element>

+ implements ElementList<Element>, NodeListWrapper {

final List<Node> _nodeList;

$if JSINTEROP

@@ -1530,7 +1530,7 @@ $else

} catch (e) {}

return 'element tag unavailable';

}

-$endif

+$endif

$if DART2JS

@DomName('Element.offsetParent')

« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | tools/dom/templates/html/impl/impl_IDBFactory.darttemplate » ('j') | no next file with comments »