Issue 1909613003: Revert "Remove the generics from _FrozenElementList: causes checked mode failures"

Issue 1909613003: Revert "Remove the generics from _FrozenElementList: causes checked mode failures" (Closed)

Created:
4 years, 8 months ago by Jacob

Modified:
4 years, 8 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, Leaf, vsm

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove the generics from _FrozenElementList: causes checked mode failures" This reverts commit 7824ac771b349fcdd07b687d2c3f33fe2ba7cfaa. BUG= Committed: https://github.com/dart-lang/sdk/commit/777e1a386e86296db46baa415831d5283d6d422e

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBFactory.darttemplate	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Jacob

I think this pattern is a good general get out of jail free card to ...

4 years, 8 months ago (2016-04-20 18:29:38 UTC) #2

Jacob

4 years, 8 months ago (2016-04-21 01:50:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
777e1a386e86296db46baa415831d5283d6d422e.